gcp: fixes image deletion #660
Conversation
|
@beraldoleal: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -30,6 +30,8 @@ spec: | |||
| value: "" # Set this to the azure image id to delete | |||
| - name: LIBVIRT_IMAGE_ID | |||
| value: "" # Set this to the libvirt image id to delete | |||
| - name: IMAGE_NAME | |||
| value: "" # Set this to the gcp image name to delete | |||
There was a problem hiding this comment.
@gsid100 as you worked on deletion recently, do you know if this may hurt other providers deletion process?
There was a problem hiding this comment.
I was working on aws snapshot deletion, this commit shouldn't affect it.
When kata config is deleted the leftover image should be deleted. Currently is not working because the expected name is IMAGE_NAME not IMAGE_ID. Fixes rhjira#KATA-3787 Signed-off-by: Beraldo Leal <[email protected]>
beraldoleal
force-pushed
the
gcp-image-delete
branch
from
1db0162 to
a5a04dc
Compare
|
Just rebased on devel to fix the enterprise contracts. @snir911 any other comments or could we merge this one? |
|
/lgtm |
|
@littlejawa as discussed on slack about the pending jobs.... I'm merging this one. thanks everyone. |
- Description of the problem which is fixed/What is the use case
When kata config is deleted the leftover image should be deleted. Currently is not working because the expected name is IMAGE_NAME not IMAGE_ID.
Fixes rhjira#KATA-3787
- What I did
Used the right key "IMAGE_NAME" instead of IMAGE_ID.
- How to verify it
- Description for the changelog
GCP: Fixed issue with image leftover when deleting kataconfig