Skip to content

Upload image files to S3 with proper mime type #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Conversation

Dantemss
Copy link
Member

@Dantemss Dantemss commented May 8, 2025

https://openstax.atlassian.net/browse/CORE-926

RAISE images were uploaded to the bucket without a content-type so this is my attempt to prevent this in the future.

@Dantemss Dantemss requested a review from jivey May 8, 2025 23:58
@Dantemss Dantemss self-assigned this May 8, 2025
@Dantemss Dantemss marked this pull request as ready for review May 9, 2025 00:00
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this slipped off my radar. Test coverage is complaining but otherwise looks good.

@Dantemss Dantemss merged commit 95b57df into main May 13, 2025
5 of 6 checks passed
@Dantemss Dantemss deleted the image-mime-type branch May 13, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants