Skip to content

Core 801 set document title for footer pages #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Mar 4, 2025

@RoyEJohnson RoyEJohnson force-pushed the CORE-801-set-document-title-for-general-pages branch from 0851acd to 282e44d Compare March 4, 2025 22:44
@RoyEJohnson RoyEJohnson requested a review from jivey March 4, 2025 22:48
@RoyEJohnson RoyEJohnson force-pushed the CORE-801-set-document-title-for-general-pages branch from 282e44d to 4020972 Compare March 4, 2025 23:11
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great for every footer page except Contact Us, maybe that's a different component type?

@RoyEJohnson
Copy link
Contributor Author

Yes, the Contact form is its own page. But it needs to have a document title, too, so I'll fix that (assuming I can).

With associated test updates
@RoyEJohnson RoyEJohnson requested a review from jivey March 5, 2025 19:27
@RoyEJohnson RoyEJohnson merged commit 29b7556 into main Mar 5, 2025
1 check passed
@RoyEJohnson RoyEJohnson deleted the CORE-801-set-document-title-for-general-pages branch March 5, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants