Skip to content

SAE bus timing changes #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

SAE bus timing changes #1102

wants to merge 1 commit into from

Conversation

drc38
Copy link
Contributor

@drc38 drc38 commented Jan 21, 2025

No description provided.

@chris8086
Copy link
Contributor

These values were shown by Michael Balzer to be incorrect in his list post on 24th January, when he attached a diff that should be used instead. I'd like to see that diff merged.

@dexterbg
Copy link
Member

Chris, this PR was just meant as a solution for those unable to apply a patch, and it only covered the first timing rework attempt.

I'll commit the final timing changes once I know these do solve the issue. If they don't solve anything, changing the timing, which otherwise has been working fine all the years, is kinda pointless.

I'm currently waiting for some definitive test results, or at least some indication of the kind "no incident since running the new timing".

@chris8086
Copy link
Contributor

Understood. I've been running the new timing for four weeks now. Just the one incident which I described on the list, and the working theory is that incident can be explained by low 12v. Today I've added immediate logging of any low voltage conditions detected by OVMS, so will monitor for a few more weeks and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants