Modules fail tests #3392
Open
Modules fail tests #3392
+99
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinowski
reviewed
Jun 16, 2025
| auto retCode = server.startModules(config); | ||
| EXPECT_TRUE(retCode.ok()) << retCode.string(); | ||
| serverGuard = std::make_unique<ServerShutdownGuard>(server); | ||
| ASSERT_EQ(server.getModule(ovms::SERVABLES_CONFIG_MANAGER_MODULE_NAME)->getState(), ovms::ModuleState::INITIALIZED); |
There was a problem hiding this comment.
Please avoid unit test crashes, we do have too much of those recently
Suggested change
| ASSERT_EQ(server.getModule(ovms::SERVABLES_CONFIG_MANAGER_MODULE_NAME)->getState(), ovms::ModuleState::INITIALIZED); | |
| ASSERT_NE(server.getModule(ovms::SERVABLES_CONFIG_MANAGER_MODULE_NAME), nullptr); | |
| ASSERT_EQ(server.getModule(ovms::SERVABLES_CONFIG_MANAGER_MODULE_NAME)->getState(), ovms::ModuleState::INITIALIZED); |
atobiszei
reviewed
Jun 16, 2025
src/test/pull_hf_model_test.cpp
Outdated
| } | ||
| }; | ||
|
|
||
| TEST(ServerModeTests, ListModelError) { |
src/test/pull_hf_model_test.cpp
Outdated
| ASSERT_EQ(server.getModule(ovms::HF_MODEL_PULL_MODULE_NAME), nullptr); | ||
| } | ||
|
|
||
| TEST(ServerModeTests, ModifyConfigError) { |
There was a problem hiding this comment.
Suggested change
| TEST(ServerModeTests, ModifyConfigError) { | |
| TEST(ServerModulesBehaviorTests, ModifyConfigModeWithMissingParamsError) { |
atobiszei
approved these changes
Jun 16, 2025
dkalinowski
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRACVS-169007
Adding unit tests for fast RC fix.
🧪 Checklist
``