[OV JS] Expose Model.reshape #30785
Open
[OV JS] Expose Model.reshape #30785
+211
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alicja Miloszewska <[email protected]>
Signed-off-by: Alicja Miloszewska <[email protected]>
Signed-off-by: Alicja Miloszewska <[email protected]>
Signed-off-by: Alicja Miloszewska <[email protected]>
Signed-off-by: Alicja Miloszewska <[email protected]>
Signed-off-by: Alicja Miloszewska <[email protected]>
praasz
reviewed
May 30, 2025
| @@ -62,3 +62,7 @@ Napi::Value PartialShapeWrap::to_string(const Napi::CallbackInfo& info) { | |||
| Napi::Value PartialShapeWrap::get_dimensions(const Napi::CallbackInfo& info) { | |||
| return cpp_to_js<ov::PartialShape, Napi::Array>(info, _partial_shape); | |||
| } | |||
|
|
|||
| ov::PartialShape PartialShapeWrap::get_value() const { | |||
There was a problem hiding this comment.
Is it required to re turn it by value or can be reference?
|
|
||
| std::map<ov::Output<ov::Node>, ov::PartialShape> ModelWrap::get_new_shapes(const Napi::Env& env, | ||
| const Napi::Value& value) { | ||
| std::map<ov::Output<ov::Node>, ov::PartialShape> new_shapes; |
There was a problem hiding this comment.
Suggested change
| std::map<ov::Output<ov::Node>, ov::PartialShape> new_shapes; | |
| std::unordered_map<ov::Output<ov::Node>, ov::PartialShape> new_shapes; |
Can be used instead?
There was a problem hiding this comment.
I don't think so, ov::Output<ov::Node> doesn't have a hash, so it cannot be a key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Model.reshapemethodjs/node/include/helper.hppand type validation helpers tojs/node/include/type_validation.hppTickets: