[CPU] support E3950 on Linux #30803
Open
[CPU] support E3950 on Linux #30803
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
category: inference
This was referenced May 30, 2025
praasz
approved these changes
Jun 2, 2025
| @@ -547,7 +547,8 @@ void parse_cache_info_linux(const std::vector<std::vector<std::string>> system_i | |||
| sub_str = system_info_table[n][info_index].substr(endpos + 1); | |||
| core_2 = std::stoi(sub_str); | |||
|
|
|||
| if ((info_index == 1) && (core_2 - core_1 == 1)) { | |||
| if ((info_index == 1) && (core_2 - core_1 == 1) && | |||
There was a problem hiding this comment.
Is it possible to add some unit test which catch this core-dump issue on E3950?
OR updated test LinuxCpuMapCacheParserTests will cover it?
There was a problem hiding this comment.
New test case for E3950 had been added in LinuxCpuMapCacheParserTests
maxnick
approved these changes
Jun 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: