Skip to content

[CI] Update clang-format version to 18 #30805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[CI] Update clang-format version to 18 #30805

wants to merge 2 commits into from
+368 −332

Conversation

aobolensk
Copy link
Contributor

@aobolensk aobolensk commented May 30, 2025 •
edited
Loading

Details:

  • Update clang-format version to 18 on CI (align with clang-format and clang-tidy versions in Dockerfile)
  • Apply new clang-format remarks
  • Update clang-format version in coding style docs and contributing guide

Tickets:

  • N/A

@aobolensk aobolensk requested review from a team as code owners May 30, 2025 21:31
@aobolensk aobolensk requested review from zKulesza and removed request for a team May 30, 2025 21:31
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: docs OpenVINO documentation github_actions Pull requests that update GitHub Actions code category: JS API OpenVino JS API Bindings labels May 30, 2025
@aobolensk aobolensk force-pushed the clang-format-18-update branch from 36d1e3f to f5a7858 Compare May 30, 2025 21:48
@aobolensk aobolensk requested review from a team as code owners May 30, 2025 21:48
@aobolensk aobolensk requested review from mvafin, cavusmustafa and mlukasze and removed request for a team May 30, 2025 21:48
@github-actions github-actions bot added category: ONNX FE OpenVINO ONNX FrontEnd category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: extensions OpenVINO Extensibility Mechanism for custom operations category: CPP API OpenVINO CPP API bindings category: PyTorch FE OpenVINO PyTorch Frontend category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin labels May 30, 2025
@aobolensk aobolensk requested review from a team as code owners May 30, 2025 22:27
@github-actions github-actions bot added category: GPU OpenVINO GPU plugin category: TEMPLATE OpenVINO Template plugin category: dependency_changes Pull requests that update a dependency file and removed category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels May 30, 2025
@aobolensk aobolensk force-pushed the clang-format-18-update branch 3 times, most recently from d163f2b to 5218283 Compare May 30, 2025 22:53
t-jankowski
t-jankowski approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@t-jankowski t-jankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for Core part and Samples

thirdparty/itt_collector/sea_itt_lib/IttNotifyStdSrc.cpp
}; \
*api_list_ptr[i].func_ptr = reinterpret_cast<void*>(local::stub); \
continue; \
# define ITT_STUB_NO_IMPL(fn) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should thirdparty code undergo our code style rules? I think not, but it's not strong opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it is being checked intentionally. .clang-format configuration file was added there: https://github.com/openvinotoolkit/openvino/blob/master/thirdparty/itt_collector/.clang-format

gkrivor
gkrivor approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@gkrivor gkrivor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to move to 19th version, but if it requires much more tasks to do - it's ok for me.

praasz
praasz reviewed Jun 3, 2025
View reviewed changes
Copy link
Contributor

@praasz praasz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As code style is updated also the (optionally) .clang-format files could be updated for
Standard: Cpp11 -> Standard: Cpp17 to be aligned with OpenVINO C++ standard which is 17.

I've got input from @aobolensk there is no more diff to current PR changes.

@gkrivor , @maxnick , @sshlyapn , @PatrikStepan
Do you agree to update Standard in formatter?

@praasz praasz added this to the 2025.3 milestone Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorDuplensky EgorDuplensky EgorDuplensky approved these changes

@gkrivor gkrivor gkrivor approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@praasz praasz praasz approved these changes

@zKulesza zKulesza Awaiting requested review from zKulesza zKulesza is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

@mvafin mvafin Awaiting requested review from mvafin mvafin is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@mlukasze mlukasze Awaiting requested review from mlukasze mlukasze is a code owner automatically assigned from openvinotoolkit/openvino-maintainers

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

Assignees

@sshlyapn sshlyapn

@PatrikStepan PatrikStepan

@maxnick maxnick

@praasz praasz

Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: dependency_changes Pull requests that update a dependency file category: docs OpenVINO documentation category: extensions OpenVINO Extensibility Mechanism for custom operations category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: JS API OpenVino JS API Bindings category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin category: ONNX FE OpenVINO ONNX FrontEnd category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: PyTorch FE OpenVINO PyTorch Frontend category: samples OpenVINO Runtime Samples category: TEMPLATE OpenVINO Template plugin category: transformations OpenVINO Runtime library - Transformations github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
2025.3
Development

Successfully merging this pull request may close these issues.
8 participants
@aobolensk @EgorDuplensky @gkrivor @t-jankowski @praasz @sshlyapn @PatrikStepan @maxnick