Skip to content

luci-theme-*: Page <title> incomplete since OpenWrt 23.05 #7703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Self-Hosting-Group opened this issue Mar 27, 2025 · 1 comment
Open

Comments

@Self-Hosting-Group
Copy link

Self-Hosting-Group commented Mar 27, 2025

Since OpenWrt 23.05 the called page (menu name) is missing in the page title element, ${node.title} is not set.

When correcting this, it may be better for visibility to show the menu name first, then the hostname, and use | as the separator.

<title>{{ striptags(`${boardinfo.hostname ?? '?'}${node ? ` - ${node.title}` : ''}`) }} - LuCI</title>

Currently missing title:

  • <title>$HOSTNAME - LuCI</title>

But should be displayed as:

  • <title>$HOSTNAME - $TITLE - LuCI</title>

Title suggestions (examples):

  1. <title>DHCP and DNS | $HOSTNAME | LuCI</title>
  2. <title>DHCP and DNS | $HOSTNAME LuCI</title> (good with OpenWrt hostname)
  3. <title>DHCP and DNS | LuCI | $HOSTNAME</title>
  4. <title>DHCP and DNS | LuCI/$HOSTNAME</title> (good with OpenWrt hostname)
  5. <title>DHCP and DNS | $HOSTNAME</title>
  6. <title>DHCP and DNS | LuCI</title>
@Self-Hosting-Group Self-Hosting-Group changed the title LuCI page title (element) incomplete since OpenWrt 23.05 luci-theme-*: Page <title> incomplete since OpenWrt 23.05 Apr 14, 2025
Self-Hosting-Group added a commit to Self-Hosting-Group/luci that referenced this issue Apr 17, 2025
Self-Hosting-Group added a commit to Self-Hosting-Group/luci that referenced this issue Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant