-
Notifications
You must be signed in to change notification settings - Fork 1.9k
'zfs share -a' should clean noauto exports #10747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Don Brady <[email protected]>
grwilson
reviewed
Aug 19, 2020
tests/zfs-tests/tests/functional/cli_root/zfs_share/zfs_share_012_pos.ksh
Show resolved
Hide resolved
Signed-off-by: Don Brady <[email protected]>
behlendorf
approved these changes
Aug 20, 2020
grwilson
approved these changes
Aug 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #10747 +/- ##
==========================================
- Coverage 79.70% 79.54% -0.16%
==========================================
Files 394 394
Lines 124638 124640 +2
==========================================
- Hits 99342 99145 -197
- Misses 25296 25495 +199
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
This is a follow on to PR openzfs#10688 where `zfs share -a` allows the sharing of canmount=noauto datasets if they are mounted. However, when a dataset with canmount=noauto is not mounted, the command should also purge any existing entries from the exports file. Otherwise, after a reboot, the nfs server attempts to export the underlying mountpath, not the dataset. This can lead to a hard hang for existing client mounts. Instead of just skipping the adding of an export if not mounted and canmount=noauto, have it also remove an existing export of the dataset so that, after a reboot, we don't export an unmounted dataset. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Wilson <[email protected]> Signed-off-by: Don Brady <[email protected]> Closes openzfs#10747
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
This is a follow on to PR openzfs#10688 where `zfs share -a` allows the sharing of canmount=noauto datasets if they are mounted. However, when a dataset with canmount=noauto is not mounted, the command should also purge any existing entries from the exports file. Otherwise, after a reboot, the nfs server attempts to export the underlying mountpath, not the dataset. This can lead to a hard hang for existing client mounts. Instead of just skipping the adding of an export if not mounted and canmount=noauto, have it also remove an existing export of the dataset so that, after a reboot, we don't export an unmounted dataset. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Wilson <[email protected]> Signed-off-by: Don Brady <[email protected]> Closes openzfs#10747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is a follow on to PR-10688 where
zfs share -a
allows the sharing ofcanmount=noauto
datasets if they are mounted.However, when a dataset with
canmount=noauto
is not mounted, the command should also purge any existing entries from the exports file. Otherwise, after a reboot, the nfs server attempts to export the underlying mountpath, not the dataset. This can lead to a hard hang for existing client mounts.Reference: https://access.redhat.com/solutions/3540591
Description
Instead of just skipping the adding of an export if not mounted and
canmount=noauto
, have it also remove an existing export of the dataset so that, after a reboot, we don't export an unmounted dataset.How Has This Been Tested?
ZTS -
functional/cli_root/zfs_share/zfs_share_012_pos.ksh
(new test to verify behavior)Also tested in our internal testing workflows that was previously causing a hard hang
Types of changes
Checklist:
Signed-off-by
.