Fix Compiling on FreeBSD + gcc #11069

erikarn · 2020-10-15T20:09:17Z

Fix compile issues on FreeBSD/amd64 with gcc

Motivation and Context

This fixes issue #11068 .

Description

remove illumnos specific printf formatting
fix some pointers-are-not-uint64 assumptions

How Has This Been Tested?

compiled on freebsd amd64 + gcc

compile time testing for now

it shouldn't affect anything else

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Performance enhancement (non-breaking change which improves efficiency)
Code cleanup (non-breaking change which makes code smaller or more readable)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (a change to man pages or other documentation)

Checklist:

My code follows the OpenZFS code style requirements.
I have updated the documentation accordingly.
I have read the contributing document.
I have added tests to cover my changes.
I have run the ZFS Test Suite with this change applied.
All commit messages are properly formatted and contain Signed-off-by.

erikarn · 2020-10-15T21:31:52Z

There's something up with the current form of the patch on llvm, because amusingly it implements cmn_err as a format argument.

I'll update the pull request tonight.

codecov · 2020-10-16T04:20:51Z

Codecov Report

Merging #11069 (e4cce39) into master (52e585a) will increase coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11069      +/-   ##
==========================================
+ Coverage   79.46%   79.72%   +0.25%     
==========================================
  Files         398      397       -1     
  Lines      125766   125754      -12     
==========================================
+ Hits        99945   100257     +312     
+ Misses      25821    25497     -324

Flag	Coverage Δ
kernel	`80.41% <ø> (+0.06%)`	⬆️
user	`65.80% <ø> (+1.60%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/zvol_id/zvol_id_main.c	`76.31% <0.00%> (-5.27%)`	⬇️
module/lua/lmem.c	`83.33% <0.00%> (-4.17%)`	⬇️
module/zfs/spa_errlog.c	`90.83% <0.00%> (-3.82%)`	⬇️
module/zfs/zio_compress.c	`92.72% <0.00%> (-1.82%)`	⬇️
cmd/zed/agents/fmd_api.c	`88.61% <0.00%> (-1.78%)`	⬇️
cmd/zed/agents/zfs_diagnosis.c	`77.84% <0.00%> (-1.17%)`	⬇️
lib/libzfs/libzfs_changelist.c	`85.18% <0.00%> (-1.12%)`	⬇️
module/zfs/zfs_fm.c	`86.02% <0.00%> (-1.10%)`	⬇️
module/icp/io/aes.c	`29.33% <0.00%> (-1.09%)`	⬇️
module/zcommon/zfs_uio.c	`87.75% <0.00%> (-1.03%)`	⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e585a...38e6b43. Read the comment docs.

behlendorf · 2020-11-06T01:20:38Z

cc: @mjguzik you may be interested in this.

erikarn · 2020-11-06T02:16:44Z

i'll push a simpler update soon - itturns out that the openzfs codebase is peppered with format check failures that don't get picked up in Linux builds with llvm because llvm just completely ignores printf format flags for the given format attribute.

They trip on freebsd because freebsd's printf target is being checked for format attributes correctly.

So, I'll push the ioctl fixes and then a separate fix that just simply disables all of the format checks on freebsd until we can figure out a plan to fix them for both linux/freebsd.

mattmacy · 2020-11-09T21:49:56Z

@erikarn when do you think you can get that update in?

erikarn · 2020-11-09T22:29:40Z

Hi! Tomorrow? I have this week off of work and i'm just working down my TODO list right now.

…

-adrian

behlendorf · 2020-11-09T22:36:05Z

@erikarn that'd be great, thanks.

behlendorf

If you rebase this on the latest commits in the master branch it should resolve the FreeBSD CI build failures.

erikarn · 2020-11-10T03:21:44Z

Whoops! I will do that in a couple hours.

…

-adrian

On Mon, 9 Nov 2020 at 18:44, Brian Behlendorf ***@***.***> wrote: ***@***.**** approved this pull request. If you rebase this on the latest commits in the master branch it should resolve the FreeBSD CI build failures. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11069 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI2L3NPZCMWP5FLLKG3DD3SPCSJDANCNFSM4SSOIEOA> .

This shows up when compiling freebsd-head on amd64 using gcc-6.4. The lib32 compat build ends up tripping over this assumption. Signed-off-by: adrian chadd <[email protected]>

This looks like it was once from the illumnos compat code. FreeBSD doesn't have cmn_err as a compiler format attribute, so it definitely errors out. It doesn't show up on LLVM because it doesn't trigger at all. Add in the format flags but keep them behind #if 0 for now; there are too many format issues that trigger when one does format checking in the shared code. Signed-off-by: adrian chadd <[email protected]>

erikarn · 2020-11-10T16:31:54Z

hi!

I did rebase them but the freebsd failures still occur. Is that because of my diff? It looks like a variety of out of space and crashes happened?

ghost · 2020-11-10T17:39:26Z

The compress_003_pos failure on FreeBSD head is a known failure, don't worry about it.

This looks like it was once from the illumnos compat code. FreeBSD doesn't have cmn_err as a compiler format attribute, so it definitely errors out. It doesn't show up on LLVM because it doesn't trigger at all. Add in the format flags but keep them behind #if 0 for now; there are too many format issues that trigger when one does format checking in the shared code. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: adrian chadd <[email protected]> Closes #11068 Closes #11069

This shows up when compiling freebsd-head on amd64 using gcc-6.4. The lib32 compat build ends up tripping over this assumption. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: adrian chadd <[email protected]> Closes #11068 Closes #11069

This looks like it was once from the illumnos compat code. FreeBSD doesn't have cmn_err as a compiler format attribute, so it definitely errors out. It doesn't show up on LLVM because it doesn't trigger at all. Add in the format flags but keep them behind #if 0 for now; there are too many format issues that trigger when one does format checking in the shared code. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: adrian chadd <[email protected]> Closes #11068 Closes #11069

This shows up when compiling freebsd-head on amd64 using gcc-6.4. The lib32 compat build ends up tripping over this assumption. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: adrian chadd <[email protected]> Closes openzfs#11068 Closes openzfs#11069

This looks like it was once from the illumnos compat code. FreeBSD doesn't have cmn_err as a compiler format attribute, so it definitely errors out. It doesn't show up on LLVM because it doesn't trigger at all. Add in the format flags but keep them behind #if 0 for now; there are too many format issues that trigger when one does format checking in the shared code. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: adrian chadd <[email protected]> Closes openzfs#11068 Closes openzfs#11069

This shows up when compiling freebsd-head on amd64 using gcc-6.4. The lib32 compat build ends up tripping over this assumption. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: adrian chadd <[email protected]> Closes openzfs#11068 Closes openzfs#11069

This looks like it was once from the illumnos compat code. FreeBSD doesn't have cmn_err as a compiler format attribute, so it definitely errors out. It doesn't show up on LLVM because it doesn't trigger at all. Add in the format flags but keep them behind #if 0 for now; there are too many format issues that trigger when one does format checking in the shared code. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: adrian chadd <[email protected]> Closes openzfs#11068 Closes openzfs#11069

erikarn changed the title ~~Openzfs 11068~~ Fix Compiling on FreeBSD + gcc Oct 15, 2020

ghost added the Status: Work in Progress Not yet ready for general review label Oct 15, 2020

ghost self-requested a review October 15, 2020 21:39

erikarn force-pushed the openzfs-11068 branch from e4cce39 to f4a42d9 Compare November 10, 2020 00:23

behlendorf approved these changes Nov 10, 2020

View reviewed changes

Adrian Chadd added 2 commits November 9, 2020 22:02

Fix pointer-is-uint64_t-sized assumption in the ioctl path

1879e26

This shows up when compiling freebsd-head on amd64 using gcc-6.4. The lib32 compat build ends up tripping over this assumption. Signed-off-by: adrian chadd <[email protected]>

erikarn force-pushed the openzfs-11068 branch from f4a42d9 to 38e6b43 Compare November 10, 2020 06:03

ghost approved these changes Nov 10, 2020

View reviewed changes

ghost added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Work in Progress Not yet ready for general review labels Nov 10, 2020

behlendorf closed this in 79a357c Nov 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Compiling on FreeBSD + gcc #11069

Fix Compiling on FreeBSD + gcc #11069

Uh oh!

erikarn commented Oct 15, 2020 •

edited by ghost

Loading

Uh oh!

erikarn commented Oct 15, 2020

Uh oh!

codecov bot commented Oct 16, 2020 •

edited

Loading

Uh oh!

behlendorf commented Nov 6, 2020

Uh oh!

erikarn commented Nov 6, 2020

Uh oh!

mattmacy commented Nov 9, 2020

Uh oh!

erikarn commented Nov 9, 2020 via email

Uh oh!

behlendorf commented Nov 9, 2020

Uh oh!

behlendorf left a comment

Uh oh!

erikarn commented Nov 10, 2020 via email

Uh oh!

erikarn commented Nov 10, 2020

Uh oh!

ghost commented Nov 10, 2020

Uh oh!

Uh oh!

Fix Compiling on FreeBSD + gcc #11069

Fix Compiling on FreeBSD + gcc #11069

Uh oh!

Conversation

erikarn commented Oct 15, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

erikarn commented Oct 15, 2020

Uh oh!

codecov bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

behlendorf commented Nov 6, 2020

Uh oh!

erikarn commented Nov 6, 2020

Uh oh!

mattmacy commented Nov 9, 2020

Uh oh!

erikarn commented Nov 9, 2020 via email

Uh oh!

behlendorf commented Nov 9, 2020

Uh oh!

behlendorf left a comment

Choose a reason for hiding this comment

Uh oh!

erikarn commented Nov 10, 2020 via email

Uh oh!

erikarn commented Nov 10, 2020

Uh oh!

ghost commented Nov 10, 2020

Uh oh!

Uh oh!

erikarn commented Oct 15, 2020 •

edited by ghost

Loading

codecov bot commented Oct 16, 2020 •

edited

Loading