Skip to content

Remove duplicate cond_resched() definition #11131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2020

Signed-off-by: Ryan Moeller [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost ghost added the Status: Code Review Needed Ready for review and testing label Oct 29, 2020
@ghost
Copy link
Author

ghost commented Oct 29, 2020

@amotin
Copy link
Member

amotin commented Oct 29, 2020

I was thinking it could be combined with adding another primitive for maybe_yeld(), but whatever.

@behlendorf
Copy link
Contributor

I was thinking it could be combined with adding another primitive for maybe_yeld(), but whatever.

I'm fine with this as a first step. But I agree we should have portable wrappers for maybe_yield() and kern_yield(PRI_USER). For now on Linux they could both simply call cond_resched().

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 30, 2020
@behlendorf behlendorf merged commit 2f94e8f into openzfs:master Oct 31, 2020
@ghost ghost deleted the context-dedup branch November 1, 2020 13:53
behlendorf pushed a commit that referenced this pull request Nov 3, 2020
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #11131
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11131
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants