FreeBSD: Prevent NULL pointer dereference of resid #11149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spa_config_load() passes NULL into resid when doing zfs_file_read(). This would trip over when vfs.zfs.autoimport_disable=0. Sponsored by: The FreeBSD Foundation Signed-off-by: Ka Ho Ng <[email protected]>
allanjude
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
yeah, the call from spa_config_load() passes NULL as the resid argument, so this check is required for that to work.
Reviewed-By: Allan Jude [email protected]
behlendorf
approved these changes
Nov 4, 2020
khng300
force-pushed
the
fix-resid-null-fbsd
branch
2 times, most recently
from
604a31d to
a2b0398
Compare
behlendorf
pushed a commit
that referenced
this pull request
Nov 11, 2020
spa_config_load() passes NULL into resid when doing zfs_file_read(). This would trip over when vfs.zfs.autoimport_disable=0. Sponsored by: The FreeBSD Foundation Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Allan Jude <[email protected]> Signed-off-by: Ka Ho Ng <[email protected]> Closes #11149
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
spa_config_load() passes NULL into resid when doing zfs_file_read(). This would trip over when vfs.zfs.autoimport_disable=0. Sponsored by: The FreeBSD Foundation Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Allan Jude <[email protected]> Signed-off-by: Ka Ho Ng <[email protected]> Closes openzfs#11149
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
spa_config_load() passes NULL into resid when doing zfs_file_read(). This would trip over when vfs.zfs.autoimport_disable=0. Sponsored by: The FreeBSD Foundation Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Allan Jude <[email protected]> Signed-off-by: Ka Ho Ng <[email protected]> Closes openzfs#11149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change attempts to fix spa_config_load() panicking due to NULL referencing in zfs_file_read(). It could be triggered by vfs.zfs.autoimport_disable=0 in kenv.
Description
A line is added to check resid being a NULL pointer.
How Has This Been Tested?
It is checked by running with vfs.zfs.autoimport_disable=0.
Types of changes
Checklist:
Signed-off-by.