Skip to content

G/C struct znode -> z_moved #11186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

G/C struct znode -> z_moved #11186

merged 1 commit into from
Nov 10, 2020

Conversation

mjguzik
Copy link
Contributor

@mjguzik mjguzik commented Nov 10, 2020 •
edited
Loading

The field is yet another leftover from unsupported zfs_znode_move.

Signed-off-by: Mateusz Guzik [email protected]

btw boolean_t is an int-sized enum and there is 8 of them in znode_t. I'll see about converting this to straight up bool some time this week unless someone beats me to it (which would be welcome). I don't know what ABI worries (if any) are to be here.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mjguzik
G/C struct znode -> z_moved
acf69bc 
The field is yet another leftover from unsupported zfs_znode_move.

Signed-off-by: Mateusz Guzik <[email protected]>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 10, 2020
@ghost ghost added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 10, 2020
@behlendorf behlendorf merged commit 1a0b4f5 into openzfs:master Nov 10, 2020
behlendorf pushed a commit that referenced this pull request Nov 11, 2020
@mjguzik @behlendorf
G/C struct znode -> z_moved
995b80f 
The field is yet another leftover from unsupported zfs_znode_move.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Mateusz Guzik <[email protected]>
Closes #11186
@mjguzik mjguzik deleted the z_moved branch November 28, 2020 23:57
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@mjguzik @jsai20
G/C struct znode -> z_moved
ab7f07f 
The field is yet another leftover from unsupported zfs_znode_move.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Mateusz Guzik <[email protected]>
Closes openzfs#11186
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@mjguzik
G/C struct znode -> z_moved
93826bd 
The field is yet another leftover from unsupported zfs_znode_move.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Mateusz Guzik <[email protected]>
Closes openzfs#11186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjguzik @behlendorf