Linux: Fix mount/unmount when dataname name has a space #11187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom zpl_show_devname() helper should translate spaces in to the octal escape sequence \040. The getmntent(2) function is aware of this convention and properly translates the escape character back to a space when reading the fsname. Without this change the `zfs mount` and `zfs unmount` commands incorrectly detect when a dataset with names is mounted. Signed-off-by: Brian Behlendorf <[email protected]>
ghost
approved these changes
Nov 10, 2020
|
Ultra nit: typos in commit message :) |
behlendorf
added
Status: Accepted
|
@InsanePrawn thanks, I'll make sure to make the corrections when merging this. |
behlendorf
added a commit
that referenced
this pull request
Nov 12, 2020
The custom zpl_show_devname() helper should translate spaces in to the octal escape sequence \040. The getmntent(2) function is aware of this convention and properly translates the escape character back to a space when reading the fsname. Without this change the `zfs mount` and `zfs unmount` commands incorrectly detect when a dataset with a name containing spaces is mounted. Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #11182 Closes #11187
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The custom zpl_show_devname() helper should translate spaces in to the octal escape sequence \040. The getmntent(2) function is aware of this convention and properly translates the escape character back to a space when reading the fsname. Without this change the `zfs mount` and `zfs unmount` commands incorrectly detect when a dataset with a name containing spaces is mounted. Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#11182 Closes openzfs#11187
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
The custom zpl_show_devname() helper should translate spaces in to the octal escape sequence \040. The getmntent(2) function is aware of this convention and properly translates the escape character back to a space when reading the fsname. Without this change the `zfs mount` and `zfs unmount` commands incorrectly detect when a dataset with a name containing spaces is mounted. Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#11182 Closes openzfs#11187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Issue #11182.
Description
The custom
zpl_show_devname()helper should translate spaces into the octal escape sequence
\040. Thegetmntent(2)functionis aware of this convention and properly translates the escape
character back to a space when reading the fsname.
Without this change the
zfs mountandzfs unmountcommandsincorrectly detect when a dataset with names is mounted.
How Has This Been Tested?
Manually and by extending the
zfs_create_001_postest case toinclude a dataset name which includes a space.
Types of changes
Checklist:
Signed-off-by.