Skip to content

[FreeBSD] decouple ZFS_DEBUG from kernel debug settings #11213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

[FreeBSD] decouple ZFS_DEBUG from kernel debug settings #11213

merged 1 commit into from
Nov 24, 2020

Conversation

mattmacy
Copy link
Contributor

Signed-off-by: Matt Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

ghost
ghost approved these changes Nov 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this over #11211, this way the OpenZFS CI doesn't have to set WITH_KERNEL_DEBUG=true but I can do it in our internal CI where the VMs are prepared with bigger kstacks and the debugging benefit of -O0 is actually of use.

@behlendorf
Copy link
Contributor

cc: @mjguzik

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 17, 2020
@ghost ghost mentioned this pull request Nov 20, 2020
Merged
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 23, 2020
@ghost ghost mentioned this pull request Nov 24, 2020
Merged
@behlendorf behlendorf merged commit cd44f5b into openzfs:master Nov 24, 2020
@behlendorf behlendorf mentioned this pull request Nov 24, 2020
Closed
behlendorf pushed a commit that referenced this pull request Nov 25, 2020
@mattmacy @behlendorf
FreeBSD: decouple ZFS_DEBUG from kernel debug settings
45061cc 
Reviewed-by: Martelli Nikola @martellini
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Closes #11213
@mattmacy mattmacy deleted the projects/zfs_debug branch January 8, 2021 22:09
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@mattmacy @jsai20
FreeBSD: decouple ZFS_DEBUG from kernel debug settings
a65d536 
Reviewed-by: Martelli Nikola @martellini
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Closes openzfs#11213
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@mattmacy
FreeBSD: decouple ZFS_DEBUG from kernel debug settings
4956668 
Reviewed-by: Martelli Nikola @martellini
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Closes openzfs#11213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmacy @behlendorf