Skip to content

Enable ABI checks for the checkstyle workflow #11215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Automatically verify the library ABI has not changed for PRs opened
against the OpenZFS 2.0 release branch.

Motivation and Context

For the OpenZFS 2.0 release branch extend the CI checkstyle
workflow to perform the library ABI checks.

How Has This Been Tested?

Manually running the commands locally and visual inspection.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

For the OpenZFS 2.0 release branch extend the CI checkstyle
workflow to perform the library ABI checks.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 17, 2020
@behlendorf behlendorf requested a review from gmelikov November 17, 2020 21:26
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 18, 2020
@behlendorf behlendorf merged commit 813185d into openzfs:zfs-2.0-release Nov 18, 2020
behlendorf added a commit to behlendorf/zfs that referenced this pull request Dec 5, 2020
Extend the CI checkstyle workflow to perform the library ABI
checks in the master branch.  The intent is not to prevent any
ABI changes but to detect them immedidately so when they're
made it's done intentionally.

When the changing the ABI the `make storeabi` target can be
used to generate a new .abi file which can be included with
the commit.  This depends on the libabigail utility which is
available from the majority of distribution package managers.

Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11215
@behlendorf behlendorf deleted the abicheck-2.0 branch April 19, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants