Skip to content

mount_zfs: print strerror instead of errno for reporting errors. #11303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

ericonr
Copy link
Contributor

@ericonr ericonr commented Dec 7, 2020

Description

Tracking down an error message with a literal errno can be difficult,
using strerror makes the error message clearer.

I could use %m in the format string instead of %s and strerror(errno), since it's an extension supported by glibc, musl and FreeBSD, but the current code already used strerror(errno) in one place.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Tracking down an error message with the errno value can be difficult,
using strerror makes the error message clearer.

Signed-off-by: Érico Rolim <[email protected]>
@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 7, 2020
@behlendorf behlendorf merged commit 957f968 into openzfs:master Dec 10, 2020
behlendorf pushed a commit that referenced this pull request Dec 23, 2020
Tracking down an error message with the errno value can be difficult,
using strerror makes the error message clearer.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Érico Rolim <[email protected]>
Closes #11303
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Tracking down an error message with the errno value can be difficult,
using strerror makes the error message clearer.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Érico Rolim <[email protected]>
Closes openzfs#11303
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Tracking down an error message with the errno value can be difficult,
using strerror makes the error message clearer.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Érico Rolim <[email protected]>
Closes openzfs#11303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants