Skip to content

zpool: Three small fixes for #11167 #11311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

zpool: Three small fixes for #11167 #11311

merged 1 commit into from
Dec 10, 2020

Conversation

AttilaFueloep
Copy link
Contributor

Motivation and Context

Follow up fix for 0cb40fa.

Description

Remove unused variables, don't source unused libs and add missed cleanup.

How Has This Been Tested?

zfs-test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@AttilaFueloep
zpool: Three small fixes for openzfs#11167
cdd7c09 
Follow up fix for 0cb40fa. Remove unused variables, don't source
unused libs and add missed cleanup.

Signed-off-by: Attila Fülöp <[email protected]>
@AttilaFueloep
Copy link
Contributor Author

My apologies for missing these in #11167 initially.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 8, 2020
@behlendorf behlendorf requested a review from a user December 8, 2020 19:45
ghost
ghost approved these changes Dec 8, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on these!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 8, 2020
@behlendorf behlendorf merged commit b9916b4 into openzfs:master Dec 10, 2020
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this pull request Dec 23, 2020
@AttilaFueloep
ZTS: three small follow up fixes for openzfs#11167
eb74f2c 
Follow up fix for 0cb40fa. Remove unused variables, don't source
unused libs and add missed cleanup.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes openzfs#11311
@AttilaFueloep AttilaFueloep mentioned this pull request Jan 6, 2021
Merged
12 tasks
AttilaFueloep added a commit to AttilaFueloep/zfs that referenced this pull request Jan 8, 2021
@AttilaFueloep
ZTS: three small follow up fixes for openzfs#11167
57ee54b 
Follow up fix for 0cb40fa. Remove unused variables, don't source
unused libs and add missed cleanup.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes openzfs#11311
@AttilaFueloep AttilaFueloep mentioned this pull request Jan 8, 2021
Merged
13 tasks
behlendorf pushed a commit that referenced this pull request Jan 8, 2021
@AttilaFueloep @behlendorf
ZTS: three small follow up fixes for #11167
acb39fc 
Follow up fix for 0cb40fa. Remove unused variables, don't source
unused libs and add missed cleanup.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes #11311
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@AttilaFueloep @jsai20
ZTS: three small follow up fixes for openzfs#11167
054af8e 
Follow up fix for 0cb40fa. Remove unused variables, don't source
unused libs and add missed cleanup.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes openzfs#11311
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@AttilaFueloep
ZTS: three small follow up fixes for openzfs#11167
d62d6b6 
Follow up fix for 0cb40fa. Remove unused variables, don't source
unused libs and add missed cleanup.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes openzfs#11311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AttilaFueloep @behlendorf