Skip to content

Forward questions to github discussions #11383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

PrivatePuffin
Copy link
Contributor

@PrivatePuffin PrivatePuffin commented Dec 21, 2020

Motivation and Context

The issue tracker currently contains a LOT of questions, but is not really designed to handle with them:

  • Closing issues make them less accessable
  • Question-Issues don't get closed as soon as the question is solved

With the enabling of "Github Discussions", we can start to actively move those issues to Github Discussions.

Description

When creating an issue, you get a page what type of issue you want to submit.
This page also points you towards other community channels, like the mailinglist.

This PR:

  • Changes the link for questions, to the discussions system.
  • Removes the old page to create "question" type issues.
  • Rephrases it to include more general questions

How Has This Been Tested?

It's pretty basic, really.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Signed-off-by: Kjeld Schouten-Lebbing [email protected]

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 21, 2020
Instead of creating issues with type "question"
Forward to the github discussion system

Signed-off-by: Kjeld Schouten-Lebbing <[email protected]>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 21, 2020
@PrivatePuffin
Copy link
Contributor Author

@behlendorf I'm also thinking we might want to start moving "feature" tagged issues to the "Idea's" board.
Just like questions they are not "really" issues and are also quite long-term...

@behlendorf
Copy link
Contributor

behlendorf commented Dec 21, 2020

@Ornias1993 yes, I had the same thought. After working through the open questions I think it makes sense to take a look at the features.

@behlendorf behlendorf merged commit 7bbe563 into openzfs:master Dec 22, 2020
@PrivatePuffin
Copy link
Contributor Author

@behlendorf I also spend some time looking at the features...
It's a bit less clear-cut:

  1. We have 220(!) feature requests, about half of which are ancient, stale and sometimes not even relevant anymore
  2. Having them as issues does give them additional visibility and they are often valid code improvements

I've debated if we should split them into features and enhancements, but going through them I noted: that doesn't solve anything and only makes things harder for the user.

  1. Gets solved by moving them to discussions, as more active discussions get bumped to the top. So it provides a natural filter.
  2. Most of the time either a feature request gets put in as a PR regardless of the request or the feature request never gets made anyway. It doesn't look like there actually is any relationship between feature-request issue creation and the feature being made.

So I think we can (at least) start by pointing feature-requests to the discussions system when creating an issue....
and start moving more feature requests, that would lower the issue count to a little more than 500, which is workable.

jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Instead of creating issues with type "question"
Forward to the GitHub Discussion system.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Kjeld Schouten-Lebbing <[email protected]>
Closes openzfs#11383
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Instead of creating issues with type "question"
Forward to the GitHub Discussion system.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Kjeld Schouten-Lebbing <[email protected]>
Closes openzfs#11383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants