Skip to content

nvlist leaked in zpool_find_config() #11396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

nvlist leaked in zpool_find_config() #11396

wants to merge 4 commits into from

Conversation

ahrens
Copy link
Member

@ahrens ahrens commented Dec 23, 2020

Motivation and Context

In zpool_find_config(), the pools nvlist is leaked. Part of it (a
sub-nvlist) is returned in *configp, but the callers also leak that.

Additionally, in zdb.c:main(), the searchdirs is leaked.

The leaks were detected by ASAN (configure --enable-asan).

Description

This commit resolves the leaks.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 23, 2020
@ahrens
nvlist leaked in zpool_find_config()
3c09356 
In `zpool_find_config()`, the `pools` nvlist is leaked.  Part of it (a
sub-nvlist) is returned in `*configp`, but the callers also leak that.

Additionally, in `zdb.c:main()`, the `searchdirs` is leaked.

The leaks were detected by ASAN (`configure --enable-asan`).

This commit resolves the leaks.

Signed-off-by: Matthew Ahrens <[email protected]>
@ahrens
memory leak in ztest_vdev_attach_detach()
8ff2db5
@ahrens
memory leak in ztest_dmu_objset_own()
ab6ddb4
@ahrens
memory leak in zdb:import_checkpointed_state()
d80b223
behlendorf pushed a commit that referenced this pull request Dec 28, 2020
@ahrens @behlendorf
Memory leak in ztest_vdev_attach_detach()
a0316ad 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes #11396
behlendorf pushed a commit that referenced this pull request Dec 28, 2020
@ahrens @behlendorf
Memory leak in ztest_dmu_objset_own()
f014700 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes #11396
behlendorf pushed a commit that referenced this pull request Dec 28, 2020
@ahrens @behlendorf
Memory leak in zdb:import_checkpointed_state()
808e681 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes #11396
behlendorf pushed a commit that referenced this pull request Jan 5, 2021
@ahrens @behlendorf
nvlist leaked in zpool_find_config()
a296875 
In `zpool_find_config()`, the `pools` nvlist is leaked.  Part of it (a
sub-nvlist) is returned in `*configp`, but the callers also leak that.

Additionally, in `zdb.c:main()`, the `searchdirs` is leaked.

The leaks were detected by ASAN (`configure --enable-asan`).

This commit resolves the leaks.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes #11396
behlendorf pushed a commit that referenced this pull request Jan 5, 2021
@ahrens @behlendorf
Memory leak in ztest_vdev_attach_detach()
6410ee4 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes #11396
behlendorf pushed a commit that referenced this pull request Jan 5, 2021
@ahrens @behlendorf
Memory leak in ztest_dmu_objset_own()
88d7da6 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes #11396
behlendorf pushed a commit that referenced this pull request Jan 5, 2021
@ahrens @behlendorf
Memory leak in zdb:import_checkpointed_state()
88ae76a 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes #11396
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@ahrens @jsai20
nvlist leaked in zpool_find_config()
2d253f4 
In `zpool_find_config()`, the `pools` nvlist is leaked.  Part of it (a
sub-nvlist) is returned in `*configp`, but the callers also leak that.

Additionally, in `zdb.c:main()`, the `searchdirs` is leaked.

The leaks were detected by ASAN (`configure --enable-asan`).

This commit resolves the leaks.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes openzfs#11396
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@ahrens @jsai20
Memory leak in ztest_vdev_attach_detach()
6d83834 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes openzfs#11396
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@ahrens @jsai20
Memory leak in ztest_dmu_objset_own()
0a38b6d 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes openzfs#11396
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@ahrens @jsai20
Memory leak in zdb:import_checkpointed_state()
fc7abf4 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes openzfs#11396
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@ahrens
nvlist leaked in zpool_find_config()
84346c5 
In `zpool_find_config()`, the `pools` nvlist is leaked.  Part of it (a
sub-nvlist) is returned in `*configp`, but the callers also leak that.

Additionally, in `zdb.c:main()`, the `searchdirs` is leaked.

The leaks were detected by ASAN (`configure --enable-asan`).

This commit resolves the leaks.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes openzfs#11396
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@ahrens
Memory leak in ztest_vdev_attach_detach()
86b8b3c 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes openzfs#11396
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@ahrens
Memory leak in ztest_dmu_objset_own()
6bc29f3 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes openzfs#11396
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@ahrens
Memory leak in zdb:import_checkpointed_state()
1a553f6 
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes openzfs#11396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikozhukhov ikozhukhov ikozhukhov approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrens @ikozhukhov @behlendorf