Update man docs to clarify behaviour when sending compressed sends and receiving with overridden compression #11690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add information to -c flag to specify that if set you cannot override the compression on the recv side with -o compress even though the dataset shows the correct compression being set.
Added documentation for interaction with streams sent with -c not having data recompressed on the receive side only having the compress property set
Carify -c will not recompress data on recv with -o compress Signed-off-by: manfromafar <[email protected]>
manfromafar
force-pushed
the
update-man-docs
branch
from
89d2ec2 to
426cbac
Compare
behlendorf
added
Status: Code Review Needed
behlendorf
approved these changes
Mar 5, 2021
behlendorf
added
Status: Accepted
|
cc: @allanjude |
allanjude
approved these changes
Mar 6, 2021
behlendorf
pushed a commit
that referenced
this pull request
Mar 8, 2021
Docs for send and receive do not explain behavior when sending a compressed stream then receiving on a host that overrides compression with -o compress=value. The data from the send stream is written as it was from the send is the compressed form but the compression algorithm set on the receiver is the overridden version which causes some confusion as to what algorithm was actually used. Updated man docs to clarify behavior Reviewed-by: Brian Behlendorf <[email protected]> Reviewed By: Allan Jude <[email protected]> Signed-off-by: manfromafar <[email protected]> Closes #11690
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Docs for send and receive do not explain behavior when sending a compressed stream then receiving on a host that overrides compression with -o compress=value. The data from the send stream is written as it was from the send is the compressed form but the compression algorithm set on the receiver is the overridden version which causes some confusion as to what algorithm was actually used. Updated man docs to clarify behavior Reviewed-by: Brian Behlendorf <[email protected]> Reviewed By: Allan Jude <[email protected]> Signed-off-by: manfromafar <[email protected]> Closes openzfs#11690
adamdmoss
pushed a commit
to adamdmoss/zfs
that referenced
this pull request
Apr 10, 2021
Docs for send and receive do not explain behavior when sending a compressed stream then receiving on a host that overrides compression with -o compress=value. The data from the send stream is written as it was from the send is the compressed form but the compression algorithm set on the receiver is the overridden version which causes some confusion as to what algorithm was actually used. Updated man docs to clarify behavior Reviewed-by: Brian Behlendorf <[email protected]> Reviewed By: Allan Jude <[email protected]> Signed-off-by: manfromafar <[email protected]> Closes openzfs#11690
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Docs for send and receive do not explain behavior when sending a compressed stream then receiving on a host that overrides compression with -o compress=value. The data from the send stream is written as it was from the send is the compressed form but the compression algorithm set on the receiver is the overridden version which causes some confusion as to what algorithm was actually used. Updated man docs to clarify behavior Reviewed-by: Brian Behlendorf <[email protected]> Reviewed By: Allan Jude <[email protected]> Signed-off-by: manfromafar <[email protected]> Closes openzfs#11690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Docs for send and receive do not explain behaviour when sending a compressed stream then receiving on a host that overrides compression with -o compress=value.
The data from the send stream is written as it was from the send is the compressed form but the compression algorithm set on the receiver is the overridden version which causes some confusion as to what algorithm was actually used.
In the future it might be nicer if the override on compression actually did decompress then recompress the data before writing it to disk
Description
Updated man docs to clarify behaviour
How Has This Been Tested?
N/A
Types of changes
Checklist:
Signed-off-by.