Skip to content

ZTS: Improve cleanup in zpool tests #11694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2021
Merged

ZTS: Improve cleanup in zpool tests #11694

merged 1 commit into from
Mar 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2021

Motivation and Context

While digging into some ZTS failures caused by zhack segfauting, I noticed kern.corefile was left with a silly value by one of the zpool tests.

Description

  • Restore original kern.corefile value after the test.
  • Don't leave behind a frozen pool.
  • Clean up leftover vdev files.
  • Make zpool_002_pos and zpool_003_pos consistent in their handling of
    core files while here.

How Has This Been Tested?

ZTS zpool tests on FreeBSD

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

ZTS: Improve cleanup in zpool tests
f1098c3 
* Restore original kern.corefile value after the test.
* Don't leave behind a frozen pool.
* Clean up leftover vdev files.
* Make zpool_002_pos and zpool_003_pos consistent in their handling of
core files while here.

Signed-off-by: Ryan Moeller <[email protected]>
@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Mar 5, 2021
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 7, 2021
@behlendorf behlendorf merged commit b30cd70 into openzfs:master Mar 7, 2021
@ghost ghost deleted the zts-pool-party branch March 7, 2021 17:45
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
ZTS: Improve cleanup in zpool tests
350310c 
* Restore original kern.corefile value after the test.
* Don't leave behind a frozen pool.
* Clean up leftover vdev files.
* Make zpool_002_pos and zpool_003_pos consistent in their handling of
core files while here.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11694
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@adamdmoss
ZTS: Improve cleanup in zpool tests
1d1453c 
* Restore original kern.corefile value after the test.
* Don't leave behind a frozen pool.
* Clean up leftover vdev files.
* Make zpool_002_pos and zpool_003_pos consistent in their handling of
core files while here.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11694
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
ZTS: Improve cleanup in zpool tests
9ad1db4 
* Restore original kern.corefile value after the test.
* Don't leave behind a frozen pool.
* Clean up leftover vdev files.
* Make zpool_002_pos and zpool_003_pos consistent in their handling of
core files while here.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11694
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
ZTS: Improve cleanup in zpool tests
45f27ac 
* Restore original kern.corefile value after the test.
* Don't leave behind a frozen pool.
* Clean up leftover vdev files.
* Make zpool_002_pos and zpool_003_pos consistent in their handling of
core files while here.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11694
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Improve cleanup in zpool tests
6516ae6 
* Restore original kern.corefile value after the test.
* Don't leave behind a frozen pool.
* Clean up leftover vdev files.
* Make zpool_002_pos and zpool_003_pos consistent in their handling of
core files while here.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11694
behlendorf pushed a commit that referenced this pull request May 20, 2021
@behlendorf
ZTS: Improve cleanup in zpool tests
e48c17e 
* Restore original kern.corefile value after the test.
* Don't leave behind a frozen pool.
* Clean up leftover vdev files.
* Make zpool_002_pos and zpool_003_pos consistent in their handling of
core files while here.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #11694
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
ZTS: Improve cleanup in zpool tests
ba4f2a1 
* Restore original kern.corefile value after the test.
* Don't leave behind a frozen pool.
* Clean up leftover vdev files.
* Make zpool_002_pos and zpool_003_pos consistent in their handling of
core files while here.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11694
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@tonyhutter
ZTS: Improve cleanup in zpool tests
0ccffb2 
* Restore original kern.corefile value after the test.
* Don't leave behind a frozen pool.
* Clean up leftover vdev files.
* Make zpool_002_pos and zpool_003_pos consistent in their handling of
core files while here.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #11694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@behlendorf