Skip to content

Fix double sha1/sha1.o line in module/icp/Makefile.in #11852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2021
Merged

Fix double sha1/sha1.o line in module/icp/Makefile.in #11852

merged 1 commit into from
Apr 8, 2021

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Apr 7, 2021 •
edited
Loading

This is a very small I noted when examining the hashing code of zfs.
The file module/icp/Makefile.in conatains two itentical lines... this patch just removes one of them.

Motivation and Context

Code cleanup.

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

behlendorf
behlendorf approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 7, 2021
@behlendorf behlendorf merged commit 9c3b926 into openzfs:master Apr 8, 2021
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@mcmilk @adamdmoss
Fix double sha1/sha1.o line in module/icp/Makefile.in
d023429 
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#11852
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 14, 2021
@mcmilk @behlendorf
Fix double sha1/sha1.o line in module/icp/Makefile.in
a35cadc 
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#11852
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@mcmilk
Fix double sha1/sha1.o line in module/icp/Makefile.in
1f85c96 
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#11852
@mcmilk mcmilk deleted the smallfixes branch June 18, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcmilk @behlendorf @gmelikov