Skip to content

ZTS: Improve cleanup in removal_with_export #11856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2021
Merged

ZTS: Improve cleanup in removal_with_export #11856

merged 2 commits into from
Apr 9, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2021

Motivation and Context

removal/removal_with_export may occasionally fail, and part of the cleanup is being skipped on FreeBSD, which can cause later tests to fail.

Description

Kill the removal operation on every platform, not just Linux.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Apr 7, 2021
@ghost
Copy link
Author

ghost commented Apr 7, 2021

I wonder if this is why the test was flaky on FreeBSD in the first place. I'm going to run this in a loop for a while and see what happens now.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 7, 2021
@ghost
Copy link
Author

ghost commented Apr 8, 2021

The test ran without fail for 888 iterations in a FreeBSD 13 VM. Then I reverted the PR and the test failed after 5 iterations. Seems good.

Ryan Moeller added 2 commits April 8, 2021 16:37
ZTS: Improve cleanup in removal_with_export
109dab1 
Kill the removal operation on every platform, not just Linux.

Signed-off-by: Ryan Moeller <[email protected]>
ZTS: Remove removal/removal_with_export exception
d456649 
The test has been fixed and is now stable on FreeBSD.

Signed-off-by: Ryan Moeller <[email protected]>
@ghost ghost force-pushed the zts-removal branch from 824642b to d456649 Compare April 8, 2021 20:38
@ghost
Copy link
Author

ghost commented Apr 8, 2021

  • Rebased
  • Remove exception for removal_with_export on FreeBSD from zts-report.py

@behlendorf behlendorf merged commit 5d508d9 into openzfs:master Apr 9, 2021
@ghost ghost deleted the zts-removal branch April 9, 2021 09:10
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 10, 2021
@mcmilk
ZTS: Improve cleanup in removal_with_export
651b772 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@adamdmoss
ZTS: Improve cleanup in removal_with_export
c46d91b 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 10, 2021
@mcmilk
ZTS: Improve cleanup in removal_with_export
98699ef 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 14, 2021
@behlendorf
ZTS: Improve cleanup in removal_with_export
ad34215 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
ZTS: Improve cleanup in removal_with_export
e0d1163 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
ZTS: Improve cleanup in removal_with_export
54356d0 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
ZTS: Improve cleanup in removal_with_export
6824852 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
ZTS: Improve cleanup in removal_with_export
c6276ae 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Improve cleanup in removal_with_export
2a02324 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Improve cleanup in removal_with_export
2b4211f 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Improve cleanup in removal_with_export
27eb1de 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
ghost pushed a commit to truenas/zfs that referenced this pull request May 13, 2021
ZTS: Improve cleanup in removal_with_export
c493ac9 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
behlendorf pushed a commit that referenced this pull request May 20, 2021
@behlendorf
ZTS: Improve cleanup in removal_with_export
3486032 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #11856
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
ZTS: Improve cleanup in removal_with_export
e01565e 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11856
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@tonyhutter
ZTS: Improve cleanup in removal_with_export
12e25a6 
Kill the removal operation on every platform, not just Linux.
The test has been fixed and is now stable on FreeBSD.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #11856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwk404 @ikozhukhov @behlendorf