Skip to content

ZTS: fix removal_condense_export test case #11869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

ZTS: fix removal_condense_export test case #11869

merged 1 commit into from
Apr 12, 2021

Conversation

behlendorf
Copy link
Contributor

@behlendorf behlendorf commented Apr 9, 2021 •
edited
Loading

Motivation and Context

Observed fairly frequently in the CI causing false positives.

Description

It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being trigged and a test failure. To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

How Has This Been Tested?

Locally verified that the new module option is being set correctly during
the test, and when increased to 50% the test reliably fails in the same
way as the CI failures. Thus far I've been unable to reproduce the failure
at 25% locally but I'll leave it running to see if I can. In the meanwhile this
appears to be the most likely cause based on the CI logs which clearly
show the condense was never triggered.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 9, 2021
@ghost
Copy link

ghost commented Apr 9, 2021

Awesome, I was just wondering what was wrong with this test. There are exceptions for this in zts-report that can be removed now.

@behlendorf behlendorf force-pushed the zts-removal_condense_export branch from 44f9188 to 68e10fc Compare April 11, 2021 18:40
@behlendorf
Copy link
Contributor Author

@freqlabs thanks for pointing out the exception, I've removed it. I was wondering why I hadn't been seeing failures reported on FreeBSD and that explains it.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 11, 2021
@behlendorf behlendorf force-pushed the zts-removal_condense_export branch from 68e10fc to 0feff7e Compare April 11, 2021 22:59
@behlendorf
ZTS: fix removal_condense_export test case
879690a 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being trigged and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf force-pushed the zts-removal_condense_export branch from 0feff7e to 879690a Compare April 12, 2021 00:09
@behlendorf behlendorf merged commit 888700b into openzfs:master Apr 12, 2021
behlendorf added a commit to behlendorf/zfs that referenced this pull request Apr 14, 2021
@behlendorf
ZTS: fix removal_condense_export test case
7de1797 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 15, 2021
@behlendorf @mcmilk
ZTS: fix removal_condense_export test case
97708eb 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
@behlendorf behlendorf deleted the zts-removal_condense_export branch April 19, 2021 19:52
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@behlendorf
ZTS: fix removal_condense_export test case
c82a685 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@behlendorf
ZTS: fix removal_condense_export test case
cb01a6a 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@behlendorf
ZTS: fix removal_condense_export test case
0b2d400 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
@behlendorf
ZTS: fix removal_condense_export test case
b3b6b71 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@behlendorf
ZTS: fix removal_condense_export test case
a79e79a 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@behlendorf
ZTS: fix removal_condense_export test case
88bd03f 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@behlendorf
ZTS: fix removal_condense_export test case
68b8332 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
ghost pushed a commit to truenas/zfs that referenced this pull request May 13, 2021
@behlendorf
ZTS: fix removal_condense_export test case
e559964 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
behlendorf added a commit that referenced this pull request May 20, 2021
@behlendorf
ZTS: fix removal_condense_export test case
b5c3844 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #11869
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@behlendorf
ZTS: fix removal_condense_export test case
9db8e9f 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11869
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@behlendorf @tonyhutter
ZTS: fix removal_condense_export test case
0839934 
It's been observed in the CI that the required 25% of obsolete bytes
in the mapping can be to high a threshold for this test resulting in
condensing never being triggered and a test failure.  To prevent these
failures make the existing zfs_condense_indirect_obsolete_pct tuning
available so the obsolete percentage can be reduced from 25% to 5%
during this test.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #11869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @gmelikov