libuutil: purge vestigia #11873
Merged
libuutil: purge vestigia #11873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Apr 11, 2021
The follow-log so far is such: commit e5dc681 Author: Ricardo M. Correia <[email protected]> Date: Thu Aug 26 09:52:40 2010 -0700 Fix gcc ident pragma warnings Remove all ident pragmas which are unknown to gcc. Signed-off-by: Brian Behlendorf <[email protected]> commit 172bb4b Author: Brian Behlendorf <[email protected]> Date: Thu Dec 11 11:08:09 2008 -0800 Move the world out of /zfs/ and seperate out module build tree commit b128c09 Author: Brian Behlendorf <[email protected]> Date: Wed Dec 3 12:09:06 2008 -0800 Rebase to OpenSolaris b103, in the process we are removing any code which did not originate from the OpenSolaris source. These changes will be reintroduced in topic branches for easier tracking commit 34dc7c2 Author: Brian Behlendorf <[email protected]> Date: Thu Nov 20 12:01:55 2008 -0800 Initial Linux ZFS GIT Repo That, in reverse order: 1. add this file 2. add a #pragma ident 3. move it 4. remove that #pragma ident The problems with this implementation are many, but the primary one is the TMPPATHFMT macro, which is unused, and always has been Searching around for any users leads only to earlier imports of the same, identical file, i.a. into an apple repository (which does patch gethrtime() into it and gives us a copyright date of 2007), and a MidnightBSD one from 2008 Searching illumos-gate, uu_open_tmp appears, in current HEAD, three times: in the header, libuutil's mapfile ABI, and the implementation This slowly grows up to eight occurrences as one moves back to the root "OpenSolaris Launch" commit: the header, implementation, twice in libuutil's spec ABI, twice (with multilib and non-multilib paths) in libuutil.so's i386 and SPARC binary db ABIs That's 2005, and this file was abandonware /even then/ ‒ it's dead code, rotting for the past sixteen years at /least/ Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Similar situation as uu_open_tmp(), except it got caught by coverity once before and also appears in a FreeBSD build log Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Similar story ‒ nothing in accessibly recorded history has ever used it Signed-off-by: Ahelenia Ziemiańska <[email protected]>
nabijaczleweli
force-pushed
the
vestigium
branch
from
7b5a5e8 to
28a72db
Compare
|
Rebased |
mcmilk
pushed a commit
to mcmilk/zfs
that referenced
this pull request
Apr 15, 2021
Remove vestigial uu_open_tmp(). The problems with this implementation are many, but the primary one is the TMPPATHFMT macro, which is unused, and always has been. Searching around for any users leads only to earlier imports of the same, identical file, i.a. into an apple repository (which does patch gethrtime() into it and gives us a copyright date of 2007), and a MidnightBSD one from 2008. Searching illumos-gate, uu_open_tmp appears, in current HEAD, three times: in the header, libuutil's mapfile ABI, and the implementation. This slowly grows up to eight occurrences as one moves back to the root "OpenSolaris Launch" commit: the header, implementation, twice in libuutil's spec ABI, twice (with multilib and non-multilib paths) in libuutil.so's i386 and SPARC binary db ABIs. That's 2005, and this file was abandonware even then, it's dead code. The situation is similar for the uu_dprintf() family of functions and uu_dump(). Nothing in accessibly recorded history has ever used them. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#11873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See individual commit messages, #11866
Description
All-minus diffstat, babey
For later reference – used
's:/home/nabijaczleweli/store/code/zfs:/home/fedora/zfs:;s:/usr/lib/llvm-13/lib/clang/13.0.0/include/:/usr/lib/gcc/x86_64-redhat-linux/10/include/:;s:/usr/include/x86_64-linux-gnu/bits/:/usr/include/bits/:'to filter the ABIHow Has This Been Tested?
I mean, it builds?
Types of changes
-version-infobecause I don't know what to?Checklist:
Signed-off-by.