Skip to content

Crash reporting checksum error for gang block in zio_done #11896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2021
Merged

Crash reporting checksum error for gang block in zio_done #11896

merged 1 commit into from
Apr 16, 2021

Conversation

PaulZ-98
Copy link
Contributor

Fix NULL pointer dereference when reporting checksum error for gang block in zio_done.

Signed-off-by: Paul Zuchowski [email protected]
Fixes #11872

Motivation and Context

ZFS crash reporting checksum error from zio_done
#11872

Description

Determine if io_abd is NULL and protect certain calls in that case.

How Has This Been Tested?

On live system it prevented the crash.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@PaulZ-98 PaulZ-98 requested review from behlendorf and ahrens April 13, 2021 19:36
@PaulZ-98 PaulZ-98 changed the title NULL pointer dereference when reporting checksum error for gang block in zio_done Crash when reporting checksum error for gang block in zio_done Apr 13, 2021
@PaulZ-98 PaulZ-98 changed the title Crash when reporting checksum error for gang block in zio_done Crash reporting checksum error for gang block in zio_done Apr 13, 2021
@PaulZ-98
Crash in zio_done error reporting
00780d7 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Signed-off-by: Paul Zuchowski <[email protected]>
Fixes openzfs#11872
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 13, 2021
behlendorf
behlendorf approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! It looks like it's safe to call zcr->zcr_finish() with a NULL abd which was my only concern so this makes sense to me.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 15, 2021
@behlendorf behlendorf merged commit f228638 into openzfs:master Apr 16, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 21, 2021
@PaulZ-98 @behlendorf
Fix crash in zio_done error reporting
d938c6e 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@PaulZ-98
Fix crash in zio_done error reporting
0732e48 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@PaulZ-98
Fix crash in zio_done error reporting
89094f4 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@PaulZ-98
Fix crash in zio_done error reporting
eb5f469 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
@PaulZ-98
Fix crash in zio_done error reporting
f0bc248 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@PaulZ-98
Fix crash in zio_done error reporting
2ff4678 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@PaulZ-98
Fix crash in zio_done error reporting
d87857c 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@PaulZ-98
Fix crash in zio_done error reporting
60435ca 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
ghost pushed a commit to truenas/zfs that referenced this pull request May 13, 2021
@PaulZ-98
Fix crash in zio_done error reporting
4a78484 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
ghost pushed a commit to truenas/zfs that referenced this pull request May 17, 2021
@PaulZ-98
Fix crash in zio_done error reporting
0874d93 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
behlendorf pushed a commit that referenced this pull request May 20, 2021
@PaulZ-98 @behlendorf
Fix crash in zio_done error reporting
b996523 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes #11872
Closes #11896
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@PaulZ-98
Fix crash in zio_done error reporting
df04ebd 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes openzfs#11872
Closes openzfs#11896
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@PaulZ-98 @tonyhutter
Fix crash in zio_done error reporting
9755cdf 
Fix NULL pointer dereference when reporting
checksum error for gang block in zio_done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Zuchowski <[email protected]>
Closes #11872
Closes #11896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@ahrens ahrens Awaiting requested review from ahrens

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic reporting checksum error from zio_done
2 participants
@PaulZ-98 @behlendorf