FreeBSD: avoid memory allocation in arc_prune_async #11927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateusz Guzik <[email protected]>
ghost
approved these changes
Apr 22, 2021
behlendorf
approved these changes
Apr 22, 2021
amotin
reviewed
Apr 22, 2021
| int64_t nr_scan = (int64_t)arg; | ||
| #else | ||
| int64_t nr_scan = (int32_t)arg; | ||
| #endif |
| @@ -185,13 +188,14 @@ arc_prune_task(void *arg) | |||
| void | |||
| arc_prune_async(int64_t adjust) | |||
| { | |||
|
|
|||
| int64_t *adjustptr; | |||
There was a problem hiding this comment.
I'd make it void * or remove completely.
|
|
||
| *adjustptr = adjust; | ||
| adjustptr = (void *)adjust; |
There was a problem hiding this comment.
I think it would be better be brought to intptr_t first.
behlendorf
added
Status: Code Review Needed
behlendorf
added
the
Status: Revision Needed
|
@mjguzik when you get a chance can you address the review feedback in this PR. |
13 tasks
|
@tonynguien let's go ahead and move forward with the updated version of this in PR #12049. |
|
Mateusz just today answered me in private email that he does not care which of the versions is committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mateusz Guzik [email protected]
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.