Skip to content

vdev_id: variable not getting expanded under map_slot() #11959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

arshad512
Copy link
Contributor

Under function map_slot() variable passed as args
were not getting properly substituted or expanded.
This patch fixes the substitution issue.

Signed-off-by: Arshad Hussain [email protected]

Motivation and Context

Description

How Has This Been Tested?

Locally tested. As this non-expansion issue is limited to funciton.

$ bash -x ./test.sh

  • LINUX_SLOT=4
  • CHANNEL=c3bay
  • map_slot 4 c3bay
  • LINUX_SLOT=4
  • CHANNEL=c3bay
    ++ awk -v linux_slot=4 -v channel=c3bay '$1 == "slot" && $2 == linux_slot &&
    $4 ~ "^"channel"$" { print $3; exit}' ./config
  • MAPPED_SLOT=8
  • '[' -z 8 ']'
  • printf %d 8
    8$

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • [x ] My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • [x ] I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

Under function map_slot() variable passed as args
were not getting properly substituted or expanded.
This patch fixes the substitution issue.

Signed-off-by: Arshad Hussain <[email protected]>
@tonyhutter
Copy link
Contributor

I'll give this a test on our enclosures

Copy link
Contributor

@tonyhutter tonyhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on two different enclosure types and saw no issues.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 29, 2021
@behlendorf behlendorf merged commit bc9c726 into openzfs:master Apr 29, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 10, 2021
Under function map_slot() variable passed as args
were not getting properly substituted or expanded.
This patch fixes the substitution issue.

Reviewed-by: Niklas Edmundsson <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Arshad Hussain <[email protected]>
Closes openzfs#11951 
Closes openzfs#11959
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Under function map_slot() variable passed as args
were not getting properly substituted or expanded.
This patch fixes the substitution issue.

Reviewed-by: Niklas Edmundsson <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Arshad Hussain <[email protected]>
Closes openzfs#11951 
Closes openzfs#11959
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 2, 2021
Under function map_slot() variable passed as args
were not getting properly substituted or expanded.
This patch fixes the substitution issue.

Reviewed-by: Niklas Edmundsson <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Arshad Hussain <[email protected]>
Closes openzfs#11951
Closes openzfs#11959
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
Under function map_slot() variable passed as args
were not getting properly substituted or expanded.
This patch fixes the substitution issue.

Reviewed-by: Niklas Edmundsson <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Arshad Hussain <[email protected]>
Closes openzfs#11951
Closes openzfs#11959
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
Under function map_slot() variable passed as args
were not getting properly substituted or expanded.
This patch fixes the substitution issue.

Reviewed-by: Niklas Edmundsson <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Arshad Hussain <[email protected]>
Closes openzfs#11951
Closes openzfs#11959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants