-
Notifications
You must be signed in to change notification settings - Fork 1.9k
vdev_id: variable not getting expanded under map_slot() #11959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under function map_slot() variable passed as args were not getting properly substituted or expanded. This patch fixes the substitution issue. Signed-off-by: Arshad Hussain <[email protected]>
e557163
to
f62069d
Compare
I'll give this a test on our enclosures |
tonyhutter
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on two different enclosure types and saw no issues.
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
May 10, 2021
Under function map_slot() variable passed as args were not getting properly substituted or expanded. This patch fixes the substitution issue. Reviewed-by: Niklas Edmundsson <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Arshad Hussain <[email protected]> Closes openzfs#11951 Closes openzfs#11959
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Under function map_slot() variable passed as args were not getting properly substituted or expanded. This patch fixes the substitution issue. Reviewed-by: Niklas Edmundsson <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Arshad Hussain <[email protected]> Closes openzfs#11951 Closes openzfs#11959
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 2, 2021
Under function map_slot() variable passed as args were not getting properly substituted or expanded. This patch fixes the substitution issue. Reviewed-by: Niklas Edmundsson <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Arshad Hussain <[email protected]> Closes openzfs#11951 Closes openzfs#11959
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 13, 2021
Under function map_slot() variable passed as args were not getting properly substituted or expanded. This patch fixes the substitution issue. Reviewed-by: Niklas Edmundsson <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Arshad Hussain <[email protected]> Closes openzfs#11951 Closes openzfs#11959
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 13, 2021
Under function map_slot() variable passed as args were not getting properly substituted or expanded. This patch fixes the substitution issue. Reviewed-by: Niklas Edmundsson <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Arshad Hussain <[email protected]> Closes openzfs#11951 Closes openzfs#11959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under function map_slot() variable passed as args
were not getting properly substituted or expanded.
This patch fixes the substitution issue.
Signed-off-by: Arshad Hussain [email protected]
Motivation and Context
Description
How Has This Been Tested?
Locally tested. As this non-expansion issue is limited to funciton.
$ bash -x ./test.sh
++ awk -v linux_slot=4 -v channel=c3bay '$1 == "slot" && $2 == linux_slot &&
$4 ~ "^"channel"$" { print $3; exit}' ./config
8$
Types of changes
Checklist:
Signed-off-by
.