Skip to content

Linux 5.13 compat: block device revalidate_disk removal #12027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ColinIanKing
Copy link
Contributor

@ColinIanKing ColinIanKing commented May 11, 2021

Linux 5.13 finally removed the block device revalidate_disk()
in 0f00b82e5413571ed225ddbccad6882d7ea60bc7 ("block: remove the
revalidate_disk method"). Add a build time check for this and
don't use it for kernels that don't support this unused API.

Signed-off-by: Colin Ian King [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Linux 5.13 finally removed the block device revalidate_disk()
in 0f00b82e5413571ed225ddbccad6882d7ea60bc7 ("block: remove the
revalidate_disk method"). Add a build time check for this and
don't use it for kernels that don't support this unused API.

Signed-off-by: Colin Ian King <[email protected]>
@behlendorf
Copy link
Contributor

@ColinIanKing thanks for the compatibility patch. There's actually an existing PR open, #11977, with an almost identical change which is ready to merge. Sorry we didn't get it merged a little sooner to spare you the trouble, but since you're already familiar with the upstream code change it would be great if you could review the other PR. Then we can merge it right away.

@behlendorf
Copy link
Contributor

Closing, addressed by #11977.

@behlendorf behlendorf closed this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants