Correct zfs-send(8) on readonly sends #12336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
zfs-send(8) claimed you could use -pR when sending a readonly filesystem
or volume. You cannot.
The usage output for
zfs send
already reflects this.Description
As above.
I suspect this never worked, but admit I have not tried firing up an old version or going source spelunking to verify this - I just got burned by this when helping someone send|recv from a readonly import during recovery, and wanted to at a minimum ensure nobody else is misled by the man page.
(I also noticed testing for other discrepancies between the man page and usage output for the r/o case that the usage didn't list -D even though it "works" fine. I know it's a noop, and going away Real Soon Now(tm), but it seemed better to list it (and eventually have it removed with the other instances) than either leaving the discrepancy or deleting it from the man page.)
How Has This Been Tested?
Well, I ran mancheck, and looked at the man output.
If I broke something with the zfs_main.c edit, I will be quite impressed.
Types of changes
Checklist:
Signed-off-by
.