Skip to content

ABI: add no-corpus-path flag + Update ABI files with generated in CI worker #12388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gmelikov
Copy link
Member

@gmelikov gmelikov commented Jul 18, 2021

Motivation and Context

  • storeabi: add no-corpus-path flag: just try to minimize diffs
  • update ABI files with generated in CI worker: so next updates will have smaller diffs

Description

ABI was generated on latest master via CI https://github.com/gmelikov/zfs/actions/runs/1042626752

Additional notes:

After #12379 we can generate ABI description files with smaller diffs.

Unfortunately, further optimizations may be brought only with fresh libabigail, which is not in our CI and stable OS distros yet. For example, I 've found --no-comp-dir-path was only introduced since 1.7, which is pretty new https://pkgs.org/download/abigail-tools . Good example of latest abigail usage: https://android.googlesource.com/kernel/build/+/c494508%5E%21/

Someone may prepare Docker image with needed abigail-tools, but it's not one-liner to get it work with CI and other machinery (it has to work on compiled binaries).

Let's wait a little, and ask everybody to commit .abi files from CI.

How Has This Been Tested?

CI will validate it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

gmelikov added 2 commits July 18, 2021 18:57
Try to minimize diffs.

Signed-off-by: George Melikov <[email protected]>
@gmelikov
Copy link
Member Author

So, for future changes in storeabi routine we may regenerate description files in separate commit to minimize new diffs later. In this case actual ABI changes will be granular.

@gmelikov gmelikov requested a review from behlendorf July 22, 2021 08:31
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's a shame some these new options aren't available from the distributions just yet.

@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 23, 2021
behlendorf pushed a commit that referenced this pull request Jul 26, 2021
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes #12388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants