initramfs: fix zpool get argument order #14572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the zfs initramfs scripts on my system, I get various errors at initramfs stage, such as: cannot open '-o': name must begin with a letter My zfs binaries are compiled with musl libc, which may be why this happens. In any case, fix the argument order to make the zpool binary happy, and to match its --help output. Signed-off-by: Daniel Kolesa <[email protected]>
ryao
approved these changes
Mar 5, 2023
behlendorf
approved these changes
Mar 7, 2023
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Mar 7, 2023
When using the zfs initramfs scripts on my system, I get various errors at initramfs stage, such as: cannot open '-o': name must begin with a letter My zfs binaries are compiled with musl libc, which may be why this happens. In any case, fix the argument order to make the zpool binary happy, and to match its --help output. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Richard Yao <[email protected]> Signed-off-by: Daniel Kolesa <[email protected]> Closes openzfs#14572
13 tasks
behlendorf
pushed a commit
that referenced
this pull request
Mar 7, 2023
When using the zfs initramfs scripts on my system, I get various errors at initramfs stage, such as: cannot open '-o': name must begin with a letter My zfs binaries are compiled with musl libc, which may be why this happens. In any case, fix the argument order to make the zpool binary happy, and to match its --help output. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Richard Yao <[email protected]> Signed-off-by: Daniel Kolesa <[email protected]> Closes #14572
mcmilk
pushed a commit
to mcmilk/zfs
that referenced
this pull request
Mar 13, 2023
When using the zfs initramfs scripts on my system, I get various errors at initramfs stage, such as: cannot open '-o': name must begin with a letter My zfs binaries are compiled with musl libc, which may be why this happens. In any case, fix the argument order to make the zpool binary happy, and to match its --help output. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Richard Yao <[email protected]> Signed-off-by: Daniel Kolesa <[email protected]> Closes openzfs#14572
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 16, 2023
When using the zfs initramfs scripts on my system, I get various errors at initramfs stage, such as: cannot open '-o': name must begin with a letter My zfs binaries are compiled with musl libc, which may be why this happens. In any case, fix the argument order to make the zpool binary happy, and to match its --help output. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Richard Yao <[email protected]> Signed-off-by: Daniel Kolesa <[email protected]> Closes openzfs#14572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When using the zfs initramfs scripts on my system, I get various errors at initramfs stage, such as:
My zfs binaries are compiled with musl libc (as a part of the https://chimera-linux.org/ project, which utilizes
initramfs-tools, and therefore also the supporting scripts here), which may be why this happens. Or maybe it never worked at all, I have no way to test this on a glibc system.Description
Fix the argument order to match the
zpool getoutput, and to make my builds happy.How Has This Been Tested?
I rebuilt my initramfs with these changes applied, and there are no more error messages. Since it's a simple change to follow posixly-correct argument order, it will not break any other configurations.
Types of changes
Checklist:
Signed-off-by.