Colorize patchset #14621

mcmilk · 2023-03-14T00:01:17Z

Motivation and Context

This is just a rebase of these two pull requests:

Colorize zpool iostat output Colorize zpool iostat output #14459
Colorize zfs list output Colorize zfs list output #14350

The requested changes by @behlendorf and @Low-power (light blue) were added.
When the testings are fine, the changes could be applied.

I will not copy and paste the wordings of the two requests... this PR is just a sum up of the conversation of the other two pull requests.

@ethan-coe-renner - thank you, for working on this.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Performance enhancement (non-breaking change which improves efficiency)
Code cleanup (non-breaking change which makes code smaller or more readable)
Breaking change (fix or feature that would cause existing functionality to change)
Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
Documentation (a change to man pages or other documentation)

Checklist:

My code follows the OpenZFS code style requirements.
I have updated the documentation accordingly.
I have read the contributing document.
I have added tests to cover my changes.
I have run the ZFS Test Suite with this change applied.
All commit messages are properly formatted and contain Signed-off-by.

Low-power · 2023-03-14T02:45:15Z

#define ANSI_BLUE "\033[1;34m" /* light blue */

I think the difference in this color code should be reflected in its name; may be ANSI_BRIGHT_BLUE?

mcmilk · 2023-03-14T07:04:57Z

ANSI_BRIGHT_BLUE

I also thought about that, but we will not need the standard blue for anything ... so i decided to keep the ANSI_BLUE define, but with the wanted brighter color. I could just rename it and delete the standard blue define. This ANSI_BLUE color is also used by the zfs diff code - there the brighter blue is also better I think.

Low-power · 2023-03-14T07:26:51Z

Yes, we definitely want the blue in zfs diff to be brighter, and so more readable too.

mcmilk · 2023-03-14T08:35:09Z

We have two BLUE definitions now:

BOLD_BLUE - used as primary blue
ANSI_BLUE - currently unused

@Low-power - this should be fine I think :-)

Low-power · 2023-03-14T09:34:54Z

BOLD_BLUE - used as primary blue

Why not ANSI_BOLD_BLUE? I think this is an ANSI color too.

mcmilk · 2023-03-14T09:43:23Z

BOLD_BLUE - used as primary blue

Why not ANSI_BOLD_BLUE? I think this is an ANSI color too.

I have no preference with this. I can change it to some longer value like ANSI_BOLD_BLUE. But I found BOLD_BLUE okay.

Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]>

Use a bold header and colorize the space suffixes in iostat by order of magnitude like this: - K is green - M is yellow - G is red - T is lightblue - P is magenta - E is cyan - 0 space is colored gray Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes: openzfs#14459

Use a bold header row and colorize the AVAIL column based on the used space percentage of volume. We define these colors: - when > 80%, use yellow - when > 90%, use red Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes: openzfs#14350

mcmilk · 2023-03-14T22:22:54Z

BOLD_BLUE - used as primary blue

Why not ANSI_BOLD_BLUE? I think this is an ANSI color too.

@Low-power: BOLD_BLUE -> ANSI_BOLD_BLUE is DONE :)

Low-power

Tested on my system, without issue.

ethan-coe-renner · 2023-03-22T22:34:50Z

@mcmilk , thanks for making these changes!

Use a bold header and colorize the space suffixes in iostat by order of magnitude like this: - K is green - M is yellow - G is red - T is lightblue - P is magenta - E is cyan - 0 space is colored gray Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes #14621 Closes #14459

Use a bold header row and colorize the AVAIL column based on the used space percentage of volume. We define these colors: - when > 80%, use yellow - when > 90%, use red Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes #14621 Closes #14350

Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621

Use a bold header and colorize the space suffixes in iostat by order of magnitude like this: - K is green - M is yellow - G is red - T is lightblue - P is magenta - E is cyan - 0 space is colored gray Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14459

Use a bold header row and colorize the AVAIL column based on the used space percentage of volume. We define these colors: - when > 80%, use yellow - when > 90%, use red Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14350

Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621

Use a bold header and colorize the space suffixes in iostat by order of magnitude like this: - K is green - M is yellow - G is red - T is lightblue - P is magenta - E is cyan - 0 space is colored gray Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14459

Use a bold header row and colorize the AVAIL column based on the used space percentage of volume. We define these colors: - when > 80%, use yellow - when > 90%, use red Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14350

Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621

Use a bold header and colorize the space suffixes in iostat by order of magnitude like this: - K is green - M is yellow - G is red - T is lightblue - P is magenta - E is cyan - 0 space is colored gray Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14459

Use a bold header row and colorize the AVAIL column based on the used space percentage of volume. We define these colors: - when > 80%, use yellow - when > 90%, use red Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14350

Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621

Use a bold header and colorize the space suffixes in iostat by order of magnitude like this: - K is green - M is yellow - G is red - T is lightblue - P is magenta - E is cyan - 0 space is colored gray Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14459

Use a bold header row and colorize the AVAIL column based on the used space percentage of volume. We define these colors: - when > 80%, use yellow - when > 90%, use red Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14350

Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621

Use a bold header and colorize the space suffixes in iostat by order of magnitude like this: - K is green - M is yellow - G is red - T is lightblue - P is magenta - E is cyan - 0 space is colored gray Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14459

Use a bold header row and colorize the AVAIL column based on the used space percentage of volume. We define these colors: - when > 80%, use yellow - when > 90%, use red Reviewed-by: WHR <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#14621 Closes openzfs#14350

mcmilk force-pushed the colorize-patchset branch from 493d48c to ec070d4 Compare March 14, 2023 08:33

mcmilk added 3 commits March 14, 2023 23:22

Add more ANSI colors to libzfs

564e6a3

Signed-off-by: Ethan Coe-Renner <[email protected]> Signed-off-by: Tino Reichardt <[email protected]>

mcmilk force-pushed the colorize-patchset branch from 1b6a1bb to d701643 Compare March 14, 2023 22:22

behlendorf added the Status: Code Review Needed Ready for review and testing label Mar 14, 2023

Low-power approved these changes Mar 17, 2023

View reviewed changes

behlendorf approved these changes Mar 17, 2023

View reviewed changes

behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 17, 2023

behlendorf closed this in 80f2cdc Mar 24, 2023

mcmilk deleted the colorize-patchset branch March 31, 2023 07:28

ahrens mentioned this pull request Apr 15, 2023

zpool iostat columns are misaligned #14749

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Colorize patchset #14621

Colorize patchset #14621

Uh oh!

mcmilk commented Mar 14, 2023 •

edited

Loading

Uh oh!

Low-power commented Mar 14, 2023

Uh oh!

mcmilk commented Mar 14, 2023

Uh oh!

Low-power commented Mar 14, 2023

Uh oh!

mcmilk commented Mar 14, 2023

Uh oh!

Low-power commented Mar 14, 2023

Uh oh!

mcmilk commented Mar 14, 2023

Uh oh!

mcmilk commented Mar 14, 2023 •

edited

Loading

Uh oh!

Low-power left a comment

Uh oh!

ethan-coe-renner commented Mar 22, 2023

Uh oh!

Uh oh!

Colorize patchset #14621

Colorize patchset #14621

Uh oh!

Conversation

mcmilk commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Types of changes

Checklist:

Uh oh!

Low-power commented Mar 14, 2023

Uh oh!

mcmilk commented Mar 14, 2023

Uh oh!

Low-power commented Mar 14, 2023

Uh oh!

mcmilk commented Mar 14, 2023

Uh oh!

Low-power commented Mar 14, 2023

Uh oh!

mcmilk commented Mar 14, 2023

Uh oh!

mcmilk commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Low-power left a comment

Choose a reason for hiding this comment

Uh oh!

ethan-coe-renner commented Mar 22, 2023

Uh oh!

Uh oh!

mcmilk commented Mar 14, 2023 •

edited

Loading

mcmilk commented Mar 14, 2023 •

edited

Loading