Skip to content

FreeBSD: Remove extra arc_reduce_target_size() call. #14639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2023
Merged

FreeBSD: Remove extra arc_reduce_target_size() call. #14639

merged 1 commit into from
Mar 18, 2023

Conversation

amotin
Copy link
Member

@amotin amotin commented Mar 16, 2023

Remove arc_reduce_target_size() call from arc_prune_task(). The idea of arc_prune_task() is to remove external references on ARC metadata, such as vnodes. Since arc_prune_async() is called only from ARC itself, it makes no sense to create a parasitic loop between ARC eviction and the pruning, treatening to drop ARC to its minimum. I can't guess why it was added as part of FreeBSD to OpenZFS integration.

The problem should likely not be reproducible on present master after ARC eviction refactoring, but the logic is the same, and I'd like to merge this to 2.1 too.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
FreeBSD: Remove extra arc_reduce_target_size() call.
4c1cadd 
Remove arc_reduce_target_size() call from arc_prune_task().  The idea
of arc_prune_task() is to remove external references on ARC metadata,
such as vnodes. Since arc_prune_async() is called only from ARC itself,
it makes no sense to create a parasitic loop between ARC eviction and
the pruning, treatening to drop ARC to its minimum.  I can't guess why
it was added as part of FreeBSD to OpenZFS integration.

Signed-off-by:  Alexander Motin <[email protected]>
Sponsored by:   iXsystems, Inc.
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Mar 16, 2023
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 17, 2023
@behlendorf behlendorf merged commit d520f64 into openzfs:master Mar 18, 2023
@amotin amotin deleted the prune branch March 18, 2023 14:34
amotin added a commit to amotin/zfs that referenced this pull request Mar 18, 2023
@amotin
FreeBSD: Remove extra arc_reduce_target_size() call
5ee2c4b 
Remove arc_reduce_target_size() call from arc_prune_task().  The idea
of arc_prune_task() is to remove external references on ARC metadata,
such as vnodes. Since arc_prune_async() is called only from ARC itself,
it makes no sense to create a parasitic loop between ARC eviction and
the pruning, treatening to drop ARC to its minimum.  I can't guess why
it was added as part of FreeBSD to OpenZFS integration.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by:  Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#14639
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Mar 18, 2023
@amotin @andrewc12
FreeBSD: Remove extra arc_reduce_target_size() call
1428f38 
Remove arc_reduce_target_size() call from arc_prune_task().  The idea
of arc_prune_task() is to remove external references on ARC metadata,
such as vnodes. Since arc_prune_async() is called only from ARC itself,
it makes no sense to create a parasitic loop between ARC eviction and
the pruning, treatening to drop ARC to its minimum.  I can't guess why
it was added as part of FreeBSD to OpenZFS integration.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by:  Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#14639
behlendorf pushed a commit that referenced this pull request Mar 24, 2023
@amotin @behlendorf
FreeBSD: Remove extra arc_reduce_target_size() call
5219a26 
Remove arc_reduce_target_size() call from arc_prune_task().  The idea
of arc_prune_task() is to remove external references on ARC metadata,
such as vnodes. Since arc_prune_async() is called only from ARC itself,
it makes no sense to create a parasitic loop between ARC eviction and
the pruning, treatening to drop ARC to its minimum.  I can't guess why
it was added as part of FreeBSD to OpenZFS integration.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by:  Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes #14639
pcd1193182 pushed a commit to pcd1193182/zfs that referenced this pull request Sep 26, 2023
@amotin @manoj-joseph
FreeBSD: Remove extra arc_reduce_target_size() call
affeb01 
Remove arc_reduce_target_size() call from arc_prune_task().  The idea
of arc_prune_task() is to remove external references on ARC metadata,
such as vnodes. Since arc_prune_async() is called only from ARC itself,
it makes no sense to create a parasitic loop between ARC eviction and
the pruning, treatening to drop ARC to its minimum.  I can't guess why
it was added as part of FreeBSD to OpenZFS integration.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by:  Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#14639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@bwatkinson bwatkinson bwatkinson approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amotin @behlendorf @bwatkinson