Skip to content

Add another bdev_io_acct case for Linux 6.3+ compat #14668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

rincebrain
Copy link
Contributor

Motivation and Context

Add a case for some 6.3+ breakage that's also backported.

Description

Add a configure check and ifdef case.

How Has This Been Tested?

Something something that's what the CI is for, right?

(I'm going to go ping that bug and ask someone to test this, though they tested a prior version, as I don't have time to build a 6.3 tree just to test this right now...)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Linux 6.3+, and backports from it, changed the signatures
on bdev_io_{start,end}_acct.

Add a case for it.

Fixes: openzfs#14658

Signed-off-by: Rich Ercolani <[email protected]>
@behlendorf behlendorf added Type: Building Indicates an issue related to building binaries Status: Code Review Needed Ready for review and testing labels Mar 24, 2023
@RaitoBezarius
Copy link
Contributor

RaitoBezarius commented Mar 26, 2023

Something something that's what the CI is for, right?

It is running on my NixOS machine, through NixOS/nixpkgs#222946 for Linux 6.2.8 FWIW.

@thwalker3
Copy link

fwiw- Fedora 38 beta user here, who can confirm that I'm back up and running on 6.2.8-300.fc38.x86_64 with this patch on top of 2.1.9.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 27, 2023
@behlendorf behlendorf merged commit ae0b1f6 into openzfs:master Mar 27, 2023
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Mar 27, 2023
Linux 6.3+, and backports from it (6.2.8+), changed the
signatures on bdev_io_{start,end}_acct.  Add a case for it.  

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#14658
Closes openzfs#14668
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Mar 27, 2023
Linux 6.3+, and backports from it (6.2.8+), changed the
signatures on bdev_io_{start,end}_acct.  Add a case for it.  

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#14658
Closes openzfs#14668
behlendorf pushed a commit that referenced this pull request Mar 28, 2023
Linux 6.3+, and backports from it (6.2.8+), changed the
signatures on bdev_io_{start,end}_acct.  Add a case for it.  

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes #14658
Closes #14668
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 5, 2023
Linux 6.3+, and backports from it (6.2.8+), changed the
signatures on bdev_io_{start,end}_acct.  Add a case for it.  

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#14658
Closes openzfs#14668
Mic92 pushed a commit to Mic92/nixpkgs that referenced this pull request May 7, 2023
Mic92 pushed a commit to TUM-DSE/nixpkgs that referenced this pull request Jun 11, 2023
pcd1193182 pushed a commit to pcd1193182/zfs that referenced this pull request Sep 26, 2023
Linux 6.3+, and backports from it (6.2.8+), changed the
signatures on bdev_io_{start,end}_acct.  Add a case for it.  

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#14658
Closes openzfs#14668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants