Skip to content

Fix "Add colored output to zfs list" #14712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix "Add colored output to zfs list" #14712

merged 1 commit into from
Apr 5, 2023

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Apr 3, 2023 •
edited
Loading

Running zfs list -o avail rpool resulted in a core dump :/ This commit will fix this.

Run the needed overhead only, when use_color() is true.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mcmilk mcmilk mentioned this pull request Apr 3, 2023
Closed
grwilson
grwilson approved these changes Apr 4, 2023
View reviewed changes
@mcmilk
Fix "Add colored output to zfs list"
4f56188 
Running `zfs list -o avail rpool` resulted in a core dump :/
This commit will fix this.

Run the needed overhead only, when `use_color()` is true.

Signed-off-by: Tino Reichardt <[email protected]>
@mcmilk mcmilk force-pushed the fix-colorize-patchset branch from eb99e4d to 4f56188 Compare April 4, 2023 05:38
@mcmilk mcmilk requested a review from grwilson April 4, 2023 06:36
@behlendorf behlendorf merged commit 6ecdd35 into openzfs:master Apr 5, 2023
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Apr 5, 2023
@mcmilk @andrewc12
Fix "Add colored output to zfs list"
3008934 
Running `zfs list -o avail rpool` resulted in a core dump.
This commit will fix this.

Run the needed overhead only, when `use_color()` is true.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Wilson <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#14712
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 6, 2023
@mcmilk @tonyhutter
Fix "Add colored output to zfs list"
952bddf 
Running `zfs list -o avail rpool` resulted in a core dump.
This commit will fix this.

Run the needed overhead only, when `use_color()` is true.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Wilson <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#14712
@mcmilk mcmilk deleted the fix-colorize-patchset branch April 9, 2023 10:17
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 13, 2023
@mcmilk @tonyhutter
Fix "Add colored output to zfs list"
3d9f370 
Running `zfs list -o avail rpool` resulted in a core dump.
This commit will fix this.

Run the needed overhead only, when `use_color()` is true.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Wilson <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#14712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@grwilson grwilson grwilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcmilk @behlendorf @grwilson