libzfs: sendrecv: send_progress_thread: handle SIGINFO/SIGUSR1 #15113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
force-pushed
the
zfs-sendrecv-SIGINFO
branch
2 times, most recently
from
96813ab to
1ca595d
Compare
POSIX timers target the process, not the thread (as does SIGINFO), so we need to block it in the main thread which will die if interrupted. Ref: https://101010.pl/@[email protected]/110731819189629373 Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Current semantics are preserved, /except/ no-flag "zfs send" can now receive SIGUSR1/SIGINFO will write the progress. Closes: https://101010.pl/@[email protected]/110731819189629373 Signed-off-by: Ahelenia Ziemiańska <[email protected]>
nabijaczleweli
force-pushed
the
zfs-sendrecv-SIGINFO
branch
from
1ca595d to
1258219
Compare
lundman
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Thanks for this, it was a shame openzfs/openzfs#638 got left behind.
| @@ -57,7 +57,7 @@ libzfs_la_LIBADD = \ | |||
| libzutil.la \ | |||
| libuutil.la | |||
|
|
|||
| libzfs_la_LIBADD += -lm $(LIBCRYPTO_LIBS) $(ZLIB_LIBS) $(LIBFETCH_LIBS) $(LTLIBINTL) | |||
| libzfs_la_LIBADD += -lrt -lm $(LIBCRYPTO_LIBS) $(ZLIB_LIBS) $(LIBFETCH_LIBS) $(LTLIBINTL) | |||
There was a problem hiding this comment.
this will cause issues on macOS and Windows, but they aren't in upstream yet, so you can skip over it. I will add $(LIBCLOCK_GETTIME) if'en those PRs land.
behlendorf
approved these changes
Aug 7, 2023
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Aug 25, 2023
POSIX timers target the process, not the thread (as does SIGINFO), so we need to block it in the main thread which will die if interrupted. Ref: https://101010.pl/@[email protected]/110731819189629373 Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Jorgen Lundman <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#15113
behlendorf
pushed a commit
that referenced
this pull request
Aug 25, 2023
POSIX timers target the process, not the thread (as does SIGINFO), so we need to block it in the main thread which will die if interrupted. Ref: https://101010.pl/@[email protected]/110731819189629373 Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Jorgen Lundman <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #15113
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
POSIX timers target the process, not the thread (as does SIGINFO), so we need to block it in the main thread which will die if interrupted. Ref: https://101010.pl/@[email protected]/110731819189629373 Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Jorgen Lundman <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#15113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
https://101010.pl/@[email protected]/110731819189629373
Current semantics are unchanged, except no-flag "zfs send" can now receive SIGUSR1/SIGINFO to write the progress like with -v.
Description
The thread is re-driven to use timer_create() with SIGUSR1 and pause(). Then it's dead-easy to just not timer_create() if neither of -vV.
How Has This Been Tested?
Manually by
./zfs send filling/store/nabijaczleweli/store.nabijaczleweli.xyz@2023-06-11-pre-bookworm | { sleep 3; wc -c ; }(with varying -v/-V presence) andwhile :; do pkill -USR1 zfs; donesimultaneously.Types of changes
Checklist:
Signed-off-by.