-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[2.2] spa: make read/write queues configurable #15695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
behlendorf
merged 1 commit into
openzfs:zfs-2.2.3-staging
from
robn:spa-taskq-parameterise-2.2
Dec 22, 2023
Merged
[2.2] spa: make read/write queues configurable #15695
behlendorf
merged 1 commit into
openzfs:zfs-2.2.3-staging
from
robn:spa-taskq-parameterise-2.2
Dec 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
@robn this change also needs to be fixed up to resolve the CentOS 7 compile warning. https://build.openzfs.org/builders/CentOS%207%20x86_64%20%28TEST%29/builds/1559 |
Ahh crap, this is from before the FreeBSD fixes too. Wow, how'd I stuff that up. #15696 is similarly busted. Will push update in an hour or two. |
We are finding that as customers get larger and faster machines (hundreds of cores, large NVMe-backed pools) they keep hitting relatively low performance ceilings. Our profiling work almost always finds that they're running into bottlenecks on the SPA IO taskqs. Unfortunately there's often little we can advise at that point, because there's very few ways to change behaviour without patching. This commit adds two load-time parameters `zio_taskq_read` and `zio_taskq_write` that can configure the READ and WRITE IO taskqs directly. This achieves two goals: it gives operators (and those that support them) a way to tune things without requiring a custom build of OpenZFS, which is often not possible, and it lets us easily try different config variations in a variety of environments to inform the development of better defaults for these kind of systems. Because tuning the IO taskqs really requires a fairly deep understanding of how IO in ZFS works, and generally isn't needed without a pretty serious workload and an ability to identify bottlenecks, only minimal documentation is provided. Its expected that anyone using this is going to have the source code there as well. Signed-off-by: Rob Norris <[email protected]> Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc.
a0aeea0
to
ef9a67e
Compare
Pushed. |
robn
added a commit
to robn/zfs
that referenced
this pull request
Jan 11, 2024
Missed in openzfs#15695, backporting openzfs#15675. Signed-off-by: Rob Norris <[email protected]>
robn
added a commit
to robn/zfs
that referenced
this pull request
Jan 11, 2024
Missed in openzfs#15695, backporting openzfs#15675. Signed-off-by: Rob Norris <[email protected]>
13 tasks
robn
added a commit
to robn/zfs
that referenced
this pull request
Jan 12, 2024
Missed in openzfs#15695, backporting openzfs#15675. Signed-off-by: Rob Norris <[email protected]>
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Jan 15, 2024
Missed in openzfs#15695, backporting openzfs#15675. Signed-off-by: Rob Norris <[email protected]>
behlendorf
pushed a commit
that referenced
this pull request
Jan 16, 2024
Missed in #15695, backporting #15675. Signed-off-by: Rob Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #15675 to 2.2.
Note that master has removed
ZTI_BATCH
and addedZTI_SYNC
. This PR matches 2.2, that is, it acceptsbatch
instead ofsync
. Comments and manpages have been updated accordingly.Motivation and Context
We are finding that as customers get larger and faster machines (hundreds of cores, large NVMe-backed pools) they keep hitting relatively low performance ceilings. Our profiling work almost always finds that they're running into bottlenecks on the SPA IO taskqs. Unfortunately there's often little we can advise at that point, because there's very few ways to change behaviour without patching.
Description
This commit adds two load-time parameters
zio_taskq_read
andzio_taskq_write
that can configure the READ and WRITE IO taskqs directly.This achieves two goals: it gives operators (and those that support them) a way to tune things without requiring a custom build of OpenZFS, which is often not possible, and it lets us easily try different config variations in a variety of environments to inform the development of better defaults for these kind of systems.
Because tuning the IO taskqs really requires a fairly deep understanding of how IO in ZFS works, and generally isn't needed without a pretty serious workload and an ability to identify bottlenecks, only minimal documentation is provided. Its expected that anyone using this is going to have the source code there as well.
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
How Has This Been Tested?
This PR compiled and sanity checked only. Assuming it works based on #15675 and CI results.
Types of changes
Checklist:
Signed-off-by
.