Skip to content

L2ARC: Stop rebuild before setting spa_final_txg #16782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

L2ARC: Stop rebuild before setting spa_final_txg #16782

merged 1 commit into from
Nov 20, 2024

Conversation

amotin
Copy link
Member

@amotin amotin commented Nov 19, 2024

Without doing that there is a race window on export when history log write by completed rebuild dirties transaction beyond final, triggering assertion.

Closes #16714

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
L2ARC: Stop rebuild before setting spa_final_txg
7cdb40d 
Without doing that there is a race window on export when history
log write by completed rebuild dirties transaction beyond final,
triggering assertion.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#16714
behlendorf
behlendorf approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes good sense. Thanks for running this one down, it's been one of the more frequent failures I've seen the in the CI.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 19, 2024
gamanakis
gamanakis approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@gamanakis gamanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amotin thank you for this, looks good to me!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 20, 2024
@behlendorf behlendorf merged commit 0ca82c5 into openzfs:master Nov 20, 2024
24 checks passed
gamanakis pushed a commit to gamanakis/zfs that referenced this pull request Nov 20, 2024
@amotin @gamanakis
L2ARC: Stop rebuild before setting spa_final_txg
11b5b67 
Without doing that there is a race window on export when history
log write by completed rebuild dirties transaction beyond final,
triggering assertion.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Amanakis <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16714
Closes openzfs#16782
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Nov 21, 2024
@amotin @behlendorf
L2ARC: Stop rebuild before setting spa_final_txg
10fcdd5 
Without doing that there is a race window on export when history
log write by completed rebuild dirties transaction beyond final,
triggering assertion.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Amanakis <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16714
Closes openzfs#16782
@behlendorf behlendorf mentioned this pull request Nov 21, 2024
Merged
13 tasks
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Nov 21, 2024
@amotin @behlendorf
L2ARC: Stop rebuild before setting spa_final_txg
3f9af02 
Without doing that there is a race window on export when history
log write by completed rebuild dirties transaction beyond final,
triggering assertion.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Amanakis <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16714
Closes openzfs#16782
@amotin amotin deleted the l2arc_rebuild_stop branch November 21, 2024 16:38
amotin added a commit that referenced this pull request Nov 25, 2024
@snajpa @amotin
Assert if we're logging after final txg was set
d2b0ca9 
This allowed to debug #16714, fixed in #16782.  Without assertions
added here it is difficult to figure out what logs cause the problem,
since the assertion happens in sync thread context.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Pavel Snajdr <[email protected]>
Co-authored-by: Alexander Motin <[email protected]>
Closes #16795
ixhamza pushed a commit to truenas/zfs that referenced this pull request Dec 2, 2024
@amotin @ixhamza
L2ARC: Stop rebuild before setting spa_final_txg
0463f3d 
Without doing that there is a race window on export when history
log write by completed rebuild dirties transaction beyond final,
triggering assertion.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Amanakis <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16714
Closes openzfs#16782
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Dec 3, 2024
@snajpa @amotin @behlendorf
Assert if we're logging after final txg was set
a1907b0 
This allowed to debug openzfs#16714, fixed in openzfs#16782.  Without assertions
added here it is difficult to figure out what logs cause the problem,
since the assertion happens in sync thread context.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Pavel Snajdr <[email protected]>
Co-authored-by: Alexander Motin <[email protected]>
Closes openzfs#16795
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Jan 26, 2025
@amotin @lundman
L2ARC: Stop rebuild before setting spa_final_txg
a7e5602 
Without doing that there is a race window on export when history
log write by completed rebuild dirties transaction beyond final,
triggering assertion.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Amanakis <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16714
Closes openzfs#16782
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Jan 26, 2025
@snajpa @amotin @lundman
Assert if we're logging after final txg was set
cdf2f20 
This allowed to debug openzfs#16714, fixed in openzfs#16782.  Without assertions
added here it is difficult to figure out what logs cause the problem,
since the assertion happens in sync thread context.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Pavel Snajdr <[email protected]>
Co-authored-by: Alexander Motin <[email protected]>
Closes openzfs#16795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@gamanakis gamanakis gamanakis approved these changes

@tonyhutter tonyhutter Awaiting requested review from tonyhutter

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

l2arc_mfuonly_pos: VERIFY3(tx->tx_txg <= spa_final_dirty_txg(os->os_spa)) failed (64 <= 63)
3 participants
@amotin @behlendorf @gamanakis