spa: fix signature mismatch for spa_boot_init as eventhandler required

[aokblast]

Motivation and Context

I am working on KCFI for FreeBSD. As KCFI required all function signature matched.

We should have this patch for changing signature.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[amotin]

Generally the direction is right, just compilers don't appreciate it:

  module/zfs/spa_misc.c:2552:21: error: unused parameter 'dummy' [-Werror,-Wunused-parameter]
   2552 | spa_boot_init(void *dummy)
        |                     ^

Probably needs __unused.

[aokblast]

Emm, I actually add __unused before I force-push it. Here is the Github Action log.

Don't have any idea what happens.

[amotin]

@aokblast I am not sure where have you pushed it, but I don't see it in the only commit of the branch: aokblast@9eacc1e or master...aokblast:zfs:fix_spa_sig . How about figuring it out and force pushing it again?

[aokblast]

I modified it and you may see the compile error. I think it is because the __unused is not defined and it is defined in <sys/cdefs.h>. Should I include it? I assume that all kernel .c file include it. Also it compiles without error in zfs in FreeBSD base.

[ixhamza]

@aokblast - You can explicitly mark parameter as unused like this, same way it's already done in other places:

-spa_boot_init(void)
+spa_boot_init(void* unused)
 {
+       (void) unused;
        spa_config_load();
 }

Also, it would be nice if you can push your patch in a single commit.

[aokblast]

Oh, thank you!
I push it separately because I just want to trigger ci for testing.