vdev_id: symlinks creation for multipath disk partitions #17331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been observed that the symlinks are not being created for the disk partitions on multipath enabled systems. This fix addresses the issue. Signed-off-by: Diwakar Kristappagari <[email protected]>
|
@behlendorf @tonyhutter |
tonyhutter
approved these changes
May 13, 2025
ixhamza
approved these changes
May 13, 2025
robn
pushed a commit
to robn/zfs
that referenced
this pull request
May 23, 2025
It has been observed that the symlinks are not being created for the disk partitions on multipath enabled systems. This fix addresses the issue. Signed-off-by: Diwakar Kristappagari <[email protected]> Reviewed-by: Akash B <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Ameer Hamza <[email protected]> (cherry picked from commit e2ba0f7)
robn
pushed a commit
to robn/zfs
that referenced
this pull request
May 24, 2025
It has been observed that the symlinks are not being created for the disk partitions on multipath enabled systems. This fix addresses the issue. Signed-off-by: Diwakar Kristappagari <[email protected]> Reviewed-by: Akash B <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Ameer Hamza <[email protected]> (cherry picked from commit e2ba0f7)
tonyhutter
pushed a commit
that referenced
this pull request
May 28, 2025
It has been observed that the symlinks are not being created for the disk partitions on multipath enabled systems. This fix addresses the issue. Signed-off-by: Diwakar Kristappagari <[email protected]> Reviewed-by: Akash B <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Ameer Hamza <[email protected]> (cherry picked from commit e2ba0f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been observed that the symlinks are not being created for the disk partitions on multipath enabled systems. This fix addresses the issue.
Motivation and Context
It has been observed that the symlinks are not being created for the disk partitions on multipath enabled systems.
Before change:
After change:
Description
It appears that the issue is there in the vdev_id tool/script, which seems to assume partitioned multipath device names to end with 'p'[n]. However, in some cases, the devices have only the number (e.g., 1) appended as a suffix. As per linux convention If the disk WWN ends in digit, then p is appended. If name ends in letter, no p is appended. The device member ending with p1 has a total length of 17 + 2 (p1), some members have a length of 17 + 1 (1).
Examples:
This fix addresses the above issues accordingly.
How Has This Been Tested?
I have tested this manually in some of our multipath enabled systems.
Types of changes
Checklist:
Signed-off-by.