Skip to content

ZTS: Add AlmaLinux 10 #17397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ZTS: Add AlmaLinux 10 #17397

wants to merge 2 commits into from

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented May 29, 2025

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin amotin added the Status: Code Review Needed Ready for review and testing label May 29, 2025
@tonyhutter
Copy link
Contributor

This should stop the almalinux10 test failures (patch untested):

diff --git a/tests/zfs-tests/tests/functional/direct/dio_async_fio_ioengines.ksh b/tests/zfs-tests/tests/functional/direct/dio_async_fio_ioengines.ksh
index 707dfeebd..670fedf3d 100755
--- a/tests/zfs-tests/tests/functional/direct/dio_async_fio_ioengines.ksh
+++ b/tests/zfs-tests/tests/functional/direct/dio_async_fio_ioengines.ksh
@@ -67,7 +67,8 @@ if is_linux; then
        if $(grep -q "CONFIG_IO_URING=y" /boot/config-$(uname -r)); then
                if [ -e /etc/os-release ] ; then
                        source /etc/os-release
-                       if [ $PLATFORM_ID = "platform:el9" ] ; then
+                       if [ $PLATFORM_ID = "platform:el9" ] || \
+                          [ $PLATFORM_ID = "platform:el10" ] ; then
                                log_note "io_uring disabled on RHEL 9 " \
                                "variants: fails with " \
                                "'Operation not permitted'"
diff --git a/tests/zfs-tests/tests/functional/io/io_uring.ksh b/tests/zfs-tests/tests/functional/io/io_uring.ksh
index 0b55eda01..e411dba94 100755
--- a/tests/zfs-tests/tests/functional/io/io_uring.ksh
+++ b/tests/zfs-tests/tests/functional/io/io_uring.ksh
@@ -47,7 +47,7 @@ fi
 
 if [ -e /etc/os-release ] ; then
        source /etc/os-release
-       if [ $PLATFORM_ID = "platform:el9" ]; then
+       if [ $PLATFORM_ID = "platform:el9" ] || [ $PLATFORM_ID = "platform:el10" ] ; then
                log_unsupported "Disabled on RHEL 9 variants: fails with 'Operation not permitted'"
        fi
 fi

@mcmilk
Copy link
Contributor Author

mcmilk commented May 29, 2025

This should stop the almalinux10 test failures (patch untested):
...

I hoped that io_uring got supported by RHEL :-/

@tonyhutter
Copy link
Contributor

I hoped that io_uring got supported by RHEL :-/

Yea, I'm confused as well. The Alma 10 ZTS failures show:

07:32:50.51 NOTE: Checking Direct I/O with FIO async ioengine  io_uring with args --iodepth=4 --rw=rw
07:32:50.70 fio: pid=546710, err=1/file:engines/io_uring.c:1049, func=io_queue_init, error=Operation not permitted

But then again, I see this on Alma 9.6:

$  grep -i uring /boot/config-$(uname -r)
CONFIG_IO_URING=y

So I dunno 🤷‍♂️

@mcmilk
Copy link
Contributor Author

mcmilk commented May 29, 2025

I hoped that io_uring got supported by RHEL :-/

Yea, I'm confused as well. The Alma 10 ZTS failures show:

07:32:50.51 NOTE: Checking Direct I/O with FIO async ioengine  io_uring with args --iodepth=4 --rw=rw
07:32:50.70 fio: pid=546710, err=1/file:engines/io_uring.c:1049, func=io_queue_init, error=Operation not permitted

But then again, I see this on Alma 9.6:

$  grep -i uring /boot/config-$(uname -r)
CONFIG_IO_URING=y

So I dunno 🤷‍♂️

I found a way to enable io_uring on el9 + el10 ... I will provide a second commit tomorrow.

@mcmilk
Copy link
Contributor Author

mcmilk commented May 30, 2025

@behlendorf - should I rebase?

@amotin
Copy link
Member

amotin commented May 30, 2025

@mcmilk Yes, please.

mcmilk added 2 commits May 30, 2025 17:33
Signed-off-by: Tino Reichardt <[email protected]>
The io_uring interface is available as a Technology Preview.
Details: https://access.redhat.com/solutions/4723221

Signed-off-by: Tino Reichardt <[email protected]>
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rebase, I can merge this once the CI completes.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 30, 2025
behlendorf pushed a commit that referenced this pull request May 30, 2025
The io_uring interface is available as a Technology Preview.
Details: https://access.redhat.com/solutions/4723221

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes #17397
behlendorf pushed a commit to tonyhutter/zfs that referenced this pull request May 30, 2025
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#17397
behlendorf pushed a commit to tonyhutter/zfs that referenced this pull request May 30, 2025
The io_uring interface is available as a Technology Preview.
Details: https://access.redhat.com/solutions/4723221

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#17397
@mcmilk mcmilk deleted the alma10 branch May 31, 2025 08:17
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 13, 2025
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#17397
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 13, 2025
The io_uring interface is available as a Technology Preview.
Details: https://access.redhat.com/solutions/4723221

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#17397
behlendorf pushed a commit that referenced this pull request Jun 17, 2025
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes #17397
behlendorf pushed a commit that referenced this pull request Jun 17, 2025
The io_uring interface is available as a Technology Preview.
Details: https://access.redhat.com/solutions/4723221

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes #17397
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 17, 2025
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#17397
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 17, 2025
The io_uring interface is available as a Technology Preview.
Details: https://access.redhat.com/solutions/4723221

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#17397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants