Skip to content

Improve unit testing of TimerEventSource #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adam-sandor opened this issue Jan 12, 2021 · 0 comments · Fixed by #535
Closed

Improve unit testing of TimerEventSource #293

adam-sandor opened this issue Jan 12, 2021 · 0 comments · Fixed by #535
Assignees
@adam-sandor

Comments

@adam-sandor
Copy link
Collaborator

  1. reimplement TimerEventSource by uning something else then java.util.Timer, as that one is not good for mocking.
  2. implement unit tests without waiting and sleeping to remove flakyness.
@adam-sandor adam-sandor self-assigned this Jan 13, 2021
lburgazzoli added a commit to lburgazzoli/java-operator-sdk that referenced this issue Sep 14, 2021
@lburgazzoli
fix: improve unit testing of TimerEventSource operator-framework#293
87b9171
lburgazzoli added a commit to lburgazzoli/java-operator-sdk that referenced this issue Sep 14, 2021
@lburgazzoli
fix: improve unit testing of TimerEventSource operator-framework#293
3d3125b
@lburgazzoli lburgazzoli mentioned this issue Sep 14, 2021
Merged
lburgazzoli added a commit to lburgazzoli/java-operator-sdk that referenced this issue Sep 14, 2021
@lburgazzoli
fix: improve unit testing of TimerEventSource operator-framework#293
0126491
lburgazzoli added a commit to lburgazzoli/java-operator-sdk that referenced this issue Sep 14, 2021
@lburgazzoli
fix: improve unit testing of TimerEventSource operator-framework#293
396f28b
lburgazzoli added a commit to lburgazzoli/java-operator-sdk that referenced this issue Sep 14, 2021
@lburgazzoli
fix: improve unit testing of TimerEventSource operator-framework#293
f53783b
metacosm pushed a commit that referenced this issue Sep 16, 2021
@lburgazzoli @metacosm
fix: improve unit testing of TimerEventSource #293
646f396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adam-sandor adam-sandor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: stop timers when closing TimerEventSources lburgazzoli/java-operator-sdk
1 participant
@adam-sandor