Skip to content

EventHandler is not properly restarted after a watcher disconnection #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
metacosm opened this issue Oct 27, 2021 · 0 comments
Closed

EventHandler is not properly restarted after a watcher disconnection #630

metacosm opened this issue Oct 27, 2021 · 0 comments
Assignees
@metacosm
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@metacosm
Copy link
Collaborator

When an error occurs that leads to watchers being closed, we also close the event handler so that events are not processed anymore. However, when we attempt a reconnection, we don't currently have any means to restart the event handler resulting in events not being processed anymore after a disconnection occurs.
@metacosm metacosm added the kind/bug Categorizes issue or PR as related to a bug. label Oct 27, 2021
@metacosm metacosm self-assigned this Oct 27, 2021
@metacosm metacosm mentioned this issue Oct 27, 2021
Closed
@snowdrop-bot snowdrop-bot mentioned this issue Oct 27, 2021
Closed
metacosm added a commit that referenced this issue Oct 27, 2021
@metacosm
fix: properly start event handler when starting the event source
4fe4bc5 
Fixes #630
adam-sandor pushed a commit that referenced this issue Oct 28, 2021
@metacosm @csviri @adam-sandor
fix: restart event handler (#632)
101db14 
Properly start event handler when starting the event source. 
Minor clean-ups.
Fixes #630
Co-authored-by: csviri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@metacosm