Skip to content

It should be possible to add controllers for different versions of the same CustomResource #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
metacosm opened this issue Oct 28, 2021 · 3 comments · Fixed by #638
Closed

It should be possible to add controllers for different versions of the same CustomResource #637

metacosm opened this issue Oct 28, 2021 · 3 comments · Fixed by #638
Assignees
@metacosm
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@metacosm
Copy link
Collaborator

The change introduced in #626 is too restrictive and will fail if we try to add several controllers for different versions of the same CustomResource.
@metacosm metacosm added the kind/bug Categorizes issue or PR as related to a bug. label Oct 28, 2021
@metacosm metacosm self-assigned this Oct 28, 2021
metacosm added a commit that referenced this issue Oct 28, 2021
@metacosm
fix: improve duplicated controller detection, add tests
d250f5a 
It is now possible to add different controllers for the same CR with
different versions.
Fixes #637.
@metacosm metacosm mentioned this issue Oct 28, 2021
Merged
metacosm added a commit that referenced this issue Oct 28, 2021
@metacosm
fix: improve duplicated controller detection, add tests
eadbdde 
It is now possible to add different controllers for the same CR with
different versions.
Fixes #637.
metacosm added a commit that referenced this issue Oct 28, 2021
@metacosm
fix: improve duplicated controller detection, add tests
7f87c44 
It is now possible to add different controllers for the same CR with
different versions.
Fixes #637.
@csviri
Copy link
Collaborator

csviri commented Oct 28, 2021 •
edited
Loading

This is not a requirement, we don't want to support multiple versions of the same CR.
This is the issue it was discussed: #94

This was referenced Oct 28, 2021
Closed
Closed
@metacosm
Copy link
Collaborator Author

I always forget that 2 versions cannot be served at the same time… so should we keep that change or revert it? Note that the jandex change is needed, though.

@csviri
Copy link
Collaborator

csviri commented Oct 29, 2021

I would revert that part so it's not confusing.

metacosm added a commit that referenced this issue Oct 29, 2021
@metacosm
fix: improve duplicated controller detection, add tests
8ad359b 
While we originally planned to make it possible to register controllers
with the same CR but with different version (see #637), that behavior
should actually be forbidden since only one CR version can be served,
see #94 for more details.
metacosm added a commit that referenced this issue Oct 29, 2021
@metacosm
fix: improve duplicated controller detection, add tests
92c388b 
While we originally planned to make it possible to register controllers
with the same CR but with different version (see #637), that behavior
should actually be forbidden since only one CR version can be served,
see #94 for more details.
metacosm added a commit that referenced this issue Oct 29, 2021
@metacosm
fix: improve duplicated controller detection, add tests
22daa8a 
While we originally planned to make it possible to register controllers
with the same CR but with different version (see #637), that behavior
should actually be forbidden since only one CR version can be served,
see #94 for more details.
metacosm added a commit that referenced this issue Oct 29, 2021
@metacosm
fix: improve duplicated controller detection, add tests
0287c0c 
While we originally planned to make it possible to register controllers
with the same CR but with different version (see #637), that behavior
should actually be forbidden since only one CR version can be served,
see #94 for more details.
adam-sandor pushed a commit that referenced this issue Nov 5, 2021
@metacosm @adam-sandor
fix: improve duplicated controller detection, add tests
53a6178 
While we originally planned to make it possible to register controllers
with the same CR but with different version (see #637), that behavior
should actually be forbidden since only one CR version can be served,
see #94 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes operator-framework/java-operator-sdk
2 participants
@metacosm @csviri