Skip to content

Tweet on release! #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Feb 2, 2022 · 11 comments · Fixed by #913
Closed

Tweet on release! #905

csviri opened this issue Feb 2, 2022 · 11 comments · Fixed by #913
Assignees
Labels
feature good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@csviri
Copy link
Collaborator

csviri commented Feb 2, 2022

Automatically tweet on the standard JOSDK account on release:
https://twitter.com/javaoperatorsdk
Github action for that:
https://github.com/marketplace/actions/send-tweet-action

@csviri csviri changed the title Tweet on release! :) Tweet on release! Feb 2, 2022
@csviri csviri added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. feature labels Feb 2, 2022
@RishiKumarRay
Copy link
Contributor

RishiKumarRay commented Feb 2, 2022

I would like to work on this, it sounds interesting, i went through the reference , do we need to first create a tweet app, actually i have worked with GitHub actions before but haven't done anything like this, so i would like to try this with your guidance please.

@csviri
Copy link
Collaborator Author

csviri commented Feb 3, 2022

I would like to work on this, it sounds interesting, i went through the reference , do we need to first create a tweet app, actually i have worked with GitHub actions before but haven't done anything like this, so i would like to try this with your guidance please.

Sure, glad to hear! feel free to create a PR, maybe try to do it with a separate account, we can then setup the credentials for the official changer in the workflow.

@RishiKumarRay
Copy link
Contributor

@csviri separate account of github , you mean ? I read we have to access keys first ?

@csviri
Copy link
Collaborator Author

csviri commented Feb 3, 2022

@RishiKumarRay I meant, maybe to experiment with separate twitter account first, to see how it works in you forked repo. Then we can add this as a step in the release workflow with a PR.

@RishiKumarRay
Copy link
Contributor

@csviri yeah sure i will do with my own account and let you know, meanwhile please assign it to me so that someone else should not claim this

@RishiKumarRay
Copy link
Contributor

RishiKumarRay commented Feb 7, 2022

@csviri i tried setting up and running , its working i just used this on push event that we can change it was just for testing . please check here
Screenshot from 2022-02-07 14-18-31

@csviri
Copy link
Collaborator Author

csviri commented Feb 7, 2022

@RishiKumarRay look good to me, could you create a PR pls?
Maybe we polish the text a bit but otherwise great!

@RishiKumarRay
Copy link
Contributor

@csviri yes ofcourse, i will be happy to make PR but before that you need to setup tweeter credentials in secrets by creating an app only after that it will work

@csviri
Copy link
Collaborator Author

csviri commented Feb 7, 2022

@RishiKumarRay sure will not merge until that is setup, but PR can be created, also this will be on release, so we can test it just on next release

@RishiKumarRay
Copy link
Contributor

@csviri thanks , i have added PR , after adding all secrets , just for testing you can use push event and later on we can test on release event. Thanks looking forward to it.

@csviri
Copy link
Collaborator Author

csviri commented Feb 7, 2022

Great, thx!! Will take a look asap

@csviri csviri linked a pull request Feb 7, 2022 that will close this issue
@csviri csviri self-assigned this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants