-
Notifications
You must be signed in to change notification settings - Fork 219
Tweet on release! #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweet on release! #913
Conversation
@RishiKumarRay we already have a relase workflow, I think this should be added rather as a next action after the release is done. So we tweet only if the release not failed. After this step: |
on: |
I mean that this step:
should go after this: In the same flow. |
@csviri can you check now hope i have done in right way now |
thx, better just this is the |
@csviri move to line number 15 in release.yml? am i right ? |
to line 36. |
@csviri oh yes , thanks i have updated this please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
will manage the account then merge, thx! @RishiKumarRay |
Yeah sure @csviri thanks |
Woot! Thank you. 🎉 |
#905