Skip to content

ErrorStatusHandler should have access to the reconcile context #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scrocquesel opened this issue Feb 25, 2022 · 0 comments · Fixed by #1033
Closed

ErrorStatusHandler should have access to the reconcile context #973

scrocquesel opened this issue Feb 25, 2022 · 0 comments · Fixed by #1033
Assignees
@csviri
Labels
error-handling feature needs-discussion Issue needs to be discussed more before working on it

Comments

@scrocquesel
Copy link
Contributor

Now that the context can contain data regarding execution of reconcile, it may be interesting to expose that data to the error handler.

As the error handler has access only to the original resource and exception, it would add additional information so the handler can persist or compensate partial reconciliation state .
@csviri csviri added error-handling feature needs-discussion Issue needs to be discussed more before working on it labels Feb 28, 2022
@csviri csviri self-assigned this Mar 14, 2022
@csviri csviri linked a pull request Mar 14, 2022 that will close this issue
feat: error handler improvements #1033
Merged
@csviri csviri closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csviri csviri

Labels
error-handling feature needs-discussion Issue needs to be discussed more before working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: error handler improvements operator-framework/java-operator-sdk
2 participants
@csviri @scrocquesel